linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	David Fries <david@fries.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix i486 suspend to disk CR4 oops
Date: Mon, 18 Aug 2008 08:42:40 +0200	[thread overview]
Message-ID: <20080818064240.GC9807@one.firstfloor.org> (raw)
In-Reply-To: <48A9180A.8020803@zytor.com>

On Sun, Aug 17, 2008 at 11:34:50PM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >>>
> >>The other alternative is to probe for the CPUID instruction (via
> >>EFLAGS.ID) -- CR4 is present if and only if CPUID exists.
> >
> >Can be already checked for with boot_cpu_data.extended_cpuid_level.
> >
> 
> I believe you mean just plain cpuid_level (which is set to -1 if CPUID 
> doesn't exist.)  extended_cpuid_level is only defined on x86-64, but all 
> x86-64 CPUs have CR4.

Yes I meant plain cpuid_level. Just wanted to mention that before someone
opencodes another cpuid test.

-Andi

  reply	other threads:[~2008-08-18  6:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-18  4:03 [PATCH] Fix i486 suspend to disk CR4 oops David Fries
2008-08-18  4:14 ` Maciej W. Rozycki
2008-08-18  4:35   ` H. Peter Anvin
2008-08-18  6:04     ` Andi Kleen
2008-08-18  6:34       ` H. Peter Anvin
2008-08-18  6:42         ` Andi Kleen [this message]
2008-08-18  6:41 ` Ingo Molnar
2008-08-18  6:45   ` H. Peter Anvin
2008-08-18  9:15   ` Pavel Machek
2008-08-18 10:16   ` Rafael J. Wysocki
2008-08-18 12:58   ` David Fries
2008-08-18 13:25     ` Ingo Molnar
2008-08-18 14:41       ` Maciej W. Rozycki
2008-08-18 14:38     ` Maciej W. Rozycki
2008-08-18 22:04     ` Pavel Machek
2008-08-18 22:10       ` H. Peter Anvin
2008-08-18 15:24   ` Dave Jones
2008-08-18 16:04     ` Lennart Sorensen
2008-08-18 17:17       ` Dave Jones
2008-08-18 17:32     ` H. Peter Anvin
2008-08-18 22:02       ` Pavel Machek
2008-08-19  3:37   ` [PATCH] i486 CR4 oops, no_console_suspend David Fries
2008-08-19  9:34     ` Ingo Molnar
2008-08-19 16:07       ` H. Peter Anvin
2008-08-21  4:17         ` David Fries
2008-08-21  5:37           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080818064240.GC9807@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=david@fries.net \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).