Re: [PATCH] i486 CR4 oops, no_console_suspend

From: David Fries <david@fries.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
	Pavel Machek <pavel@ucw.cz>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] i486 CR4 oops, no_console_suspend
Date: Mon, 18 Aug 2008 22:37:11 -0500	[thread overview]
Message-ID: <20080819033710.GD17528@spacedout.fries.net> (raw)
In-Reply-To: <20080818064120.GA28941@elte.hu>

On Mon, Aug 18, 2008 at 08:41:20AM +0200, Ingo Molnar wrote:
> 
> applied to tip/x86/urgent, thanks David. I've changed the conditions to 
> read_cr4_safe() instead - that's cleaner. Could you please check whether 
> the patch below works fine too on your box?

Yes the 486 suspends and resumes with this patch.

Is there any known problem with no_console_suspend and serial
consoles?  It worked to print the oops for me to track this down, and
Documentation/kernel-parameters.txt says it is known to work with
serial consoles, but on resume only kernel messages can output to the
serial console.  The getty on the serial port can't raed or write and
processes trying to write to the port just hang without getting any
data across.  The serial port works fine across suspends without
the no_console_suspend argument.  Does anyone else see this?

-- 
David Fries <david@fries.net>
http://fries.net/~david/ (PGP encryption key available)