* [PATCH] mm: mminit_loglevel cannot be __meminitdata anymore
@ 2008-08-15 21:02 Marcin Slusarz
2008-08-18 10:08 ` Mel Gorman
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Slusarz @ 2008-08-15 21:02 UTC (permalink / raw)
To: LKML; +Cc: Mel Gorman, Andrew Morton
mminit_loglevel is now used from mminit_verify_zonelist <- build_all_zonelists <-
1. online_pages <- memory_block_action <- memory_block_change_state <- store_mem_state (sys handler)
2. numa_zonelist_order_handler (proc handler)
so it cannot be annotated __meminit - drop it
fixes following section mismatch warning:
WARNING: vmlinux.o(.text+0x71628): Section mismatch in reference from the function mminit_verify_zonelist() to the variable .meminit.data:mminit_loglevel
The function mminit_verify_zonelist() references
the variable __meminitdata mminit_loglevel.
This is often because mminit_verify_zonelist lacks a __meminitdata
annotation or the annotation of mminit_loglevel is wrong.
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
mm/mm_init.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/mm_init.c b/mm/mm_init.c
index 936ef2e..4e0e265 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -12,7 +12,7 @@
#include "internal.h"
#ifdef CONFIG_DEBUG_MEMORY_INIT
-int __meminitdata mminit_loglevel;
+int mminit_loglevel;
#ifndef SECTIONS_SHIFT
#define SECTIONS_SHIFT 0
--
1.5.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: mminit_loglevel cannot be __meminitdata anymore
2008-08-15 21:02 [PATCH] mm: mminit_loglevel cannot be __meminitdata anymore Marcin Slusarz
@ 2008-08-18 10:08 ` Mel Gorman
0 siblings, 0 replies; 2+ messages in thread
From: Mel Gorman @ 2008-08-18 10:08 UTC (permalink / raw)
To: Marcin Slusarz; +Cc: LKML, Andrew Morton
On (15/08/08 23:02), Marcin Slusarz didst pronounce:
> mminit_loglevel is now used from mminit_verify_zonelist <- build_all_zonelists <-
>
> 1. online_pages <- memory_block_action <- memory_block_change_state <- store_mem_state (sys handler)
> 2. numa_zonelist_order_handler (proc handler)
>
> so it cannot be annotated __meminit - drop it
>
> fixes following section mismatch warning:
> WARNING: vmlinux.o(.text+0x71628): Section mismatch in reference from the function mminit_verify_zonelist() to the variable .meminit.data:mminit_loglevel
> The function mminit_verify_zonelist() references
> the variable __meminitdata mminit_loglevel.
> This is often because mminit_verify_zonelist lacks a __meminitdata
> annotation or the annotation of mminit_loglevel is wrong.
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Mel Gorman <mel@csn.ul.ie>
> Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Mel Gorman <mel@csn.ul.ie>
> ---
> mm/mm_init.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 936ef2e..4e0e265 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -12,7 +12,7 @@
> #include "internal.h"
>
> #ifdef CONFIG_DEBUG_MEMORY_INIT
> -int __meminitdata mminit_loglevel;
> +int mminit_loglevel;
>
> #ifndef SECTIONS_SHIFT
> #define SECTIONS_SHIFT 0
> --
> 1.5.4.5
>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-18 10:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-15 21:02 [PATCH] mm: mminit_loglevel cannot be __meminitdata anymore Marcin Slusarz
2008-08-18 10:08 ` Mel Gorman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).