From: "Yang, Sheng" <sheng.yang@intel.com>
To: Avi Kivity <avi@qumranet.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: Move VMX MSRs to msr-index.h
Date: Wed, 10 Sep 2008 18:44:15 +0800 [thread overview]
Message-ID: <200809101844.16091.sheng.yang@intel.com> (raw)
In-Reply-To: <48C67E57.1050309@qumranet.com>
On Tuesday 09 September 2008 21:47:03 Avi Kivity wrote:
> Sheng Yang wrote:
> > They are hardware specific MSRs, and we would use them in virtualization
> > feature detection later.
> >
> >
> >
> >
> > -
> > -#define MSR_IA32_FEATURE_CONTROL 0x3a
> > #define MSR_IA32_FEATURE_CONTROL_LOCKED 0x1
> > #define MSR_IA32_FEATURE_CONTROL_VMXON_ENABLED 0x
>
> Might as well move these two bitmask definitions.
Um... I think it's better to leave them here, for the MSR_IA32_FEATURE_CONTROL
is a MSR which can be put into msr-index.h, but the others are only bits of
MSR...
--
regards
Yang, Sheng
next prev parent reply other threads:[~2008-09-10 10:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 10:42 [RFC][PATCH 0/2] x86: Add "virt flags" Sheng Yang
2008-09-08 10:42 ` [PATCH 1/2] x86: Move VMX MSRs to msr-index.h Sheng Yang
2008-09-09 13:47 ` Avi Kivity
2008-09-10 10:44 ` Yang, Sheng [this message]
2008-09-10 14:30 ` Avi Kivity
2008-09-11 1:56 ` Yang, Sheng
2008-09-08 10:42 ` [PATCH 2/2] x86: Add "virt flags" in /proc/cpuinfo Sheng Yang
2008-09-08 14:04 ` [RFC][PATCH 0/2] x86: Add "virt flags" Andi Kleen
2008-09-08 14:09 ` Ingo Molnar
2008-09-08 15:30 ` H. Peter Anvin
2008-09-08 17:17 ` H. Peter Anvin
2008-09-09 3:32 ` Yang, Sheng
2008-09-09 6:54 [PATCH 0/2] Extend "flags" to contain HW virtualization info Sheng Yang
2008-09-09 6:54 ` [PATCH 1/2] x86: Move VMX MSRs to msr-index.h Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809101844.16091.sheng.yang@intel.com \
--to=sheng.yang@intel.com \
--cc=avi@qumranet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).