From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sheng Yang <sheng.yang@intel.com>, Avi Kivity <avi@qumranet.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC][PATCH 0/2] x86: Add "virt flags"
Date: Mon, 08 Sep 2008 08:30:47 -0700 [thread overview]
Message-ID: <48C54527.5040205@zytor.com> (raw)
In-Reply-To: <20080908140939.GH11993@elte.hu>
Ingo Molnar wrote:
>
> hm, i think extending the already existing flags category sounds like a
> better solution than the separate virtual CPU flags line in
> /proc/cpuinfo. We already have self-invented flag entries (such as
> X86_FEATURE_NOPL), and adding more for virtualization would be quite
> natural to do, as long as it's reasonably close to the meaning of a 'CPU
> feature'.
>
> Peter, what would be your preference?
>
It probably makes sense to separate these out as a separate word,
especially if they come from the hardware in any reasonable way. But
yes, adding them to the feature array makes sense.
-hpa
next prev parent reply other threads:[~2008-09-08 15:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 10:42 [RFC][PATCH 0/2] x86: Add "virt flags" Sheng Yang
2008-09-08 10:42 ` [PATCH 1/2] x86: Move VMX MSRs to msr-index.h Sheng Yang
2008-09-09 13:47 ` Avi Kivity
2008-09-10 10:44 ` Yang, Sheng
2008-09-10 14:30 ` Avi Kivity
2008-09-11 1:56 ` Yang, Sheng
2008-09-08 10:42 ` [PATCH 2/2] x86: Add "virt flags" in /proc/cpuinfo Sheng Yang
2008-09-08 14:04 ` [RFC][PATCH 0/2] x86: Add "virt flags" Andi Kleen
2008-09-08 14:09 ` Ingo Molnar
2008-09-08 15:30 ` H. Peter Anvin [this message]
2008-09-08 17:17 ` H. Peter Anvin
2008-09-09 3:32 ` Yang, Sheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C54527.5040205@zytor.com \
--to=hpa@zytor.com \
--cc=avi@qumranet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sheng.yang@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).