* [PATCH RESEND]kgdb:remove redundant function invocation
@ 2008-10-25 16:59 Qinghuang Feng
0 siblings, 0 replies; only message in thread
From: Qinghuang Feng @ 2008-10-25 16:59 UTC (permalink / raw)
To: jason.wessel; +Cc: kgdb-bugreport, linux-kernel
Sorry for my resending, the previous patch can't be applied successfully.
It seems strange to call kgdboc_option_setup with parameter of config from
configure_kgdboc(), because kgdboc_option_setup() is used to fill config
with stuff in other place. Now, kgdboc_option_setup will fill config
with config itself. But on the other hand, kgdboc_option_setup has a
additional effect to check whether config overflows or not.
Is it ok to remove kgdboc_option_setup?
Signed-off-by: Qinghuang Feng <qhfeng.kernel@gmail.com>
---
diff --git a/drivers/serial/kgdboc.c b/drivers/serial/kgdboc.c
index eadc1ab..03f683e 100644
--- a/drivers/serial/kgdboc.c
+++ b/drivers/serial/kgdboc.c
@@ -51,8 +51,7 @@ static int configure_kgdboc(void)
int tty_line = 0;
int err;
- err = kgdboc_option_setup(config);
- if (err || !strlen(config) || isspace(config[0]))
+ if (!strlen(config) || isspace(config[0]))
goto noconfig;
err = -ENODEV;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-10-25 16:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-25 16:59 [PATCH RESEND]kgdb:remove redundant function invocation Qinghuang Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).