[PATCH] cgroup: remove unused variable

[PATCH] cgroup: remove unused variable

[Luck, Tony]

From: Stephen Rothwell <sfr@canb.auug.org.au>

/scratch/sfr/next/kernel/cgroup.c: In function 'cgroup_tasks_start':
/scratch/sfr/next/kernel/cgroup.c:2107: warning: unused variable 'i'

Introduced in commit cc31edceee04a7b87f2be48f9489ebb72d264844 "cgroups:
convert tasks file to use a seq_file with shared pid array".

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Henrik Austad <henrik@austad.us>
Signed-off-by: Tony Luck <tony.luck@intel.com>

---

Linus,  I guess you don't build with CONFIG_CGROUPS=y or you'd
have fixed this, or taken one of the patches that fix it. I'm
tired of seeing the warning in my build log :-)

 kernel/cgroup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 046c160..35eebd5 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2104,7 +2104,7 @@ static void *cgroup_tasks_start(struct seq_file *s, loff_t *pos)
 	down_read(&cgrp->pids_mutex);
 	if (pid) {
 		int end = cgrp->pids_length;
-		int i;
+
 		while (index < end) {
 			int mid = (index + end) / 2;
 			if (cgrp->tasks_pids[mid] == pid) {
-- 
1.5.6.5

Re: [PATCH] cgroup: remove unused variable

[Linus Torvalds]

On Mon, 27 Oct 2008, Luck, Tony wrote:
> 
> Linus,  I guess you don't build with CONFIG_CGROUPS=y or you'd
> have fixed this, or taken one of the patches that fix it. I'm
> tired of seeing the warning in my build log :-)

Hmm.. Committed on Sunday. Should hav been in -rc2 already, no?

		Linus

Re: [PATCH] cgroup: remove unused variable

[Henrik Austad]

On Tuesday 28 October 2008 00:08:24 Linus Torvalds wrote:
> 
> On Mon, 27 Oct 2008, Luck, Tony wrote:
> > 
> > Linus,  I guess you don't build with CONFIG_CGROUPS=y or you'd
> > have fixed this, or taken one of the patches that fix it. I'm
> > tired of seeing the warning in my build log :-)
> 
> Hmm.. Committed on Sunday. Should hav been in -rc2 already, no?

yes, commit 207777664

-- 
henrik

[PATCH] cgroup: remove unused variable

[Stephen Rothwell]

/scratch/sfr/next/kernel/cgroup.c: In function 'cgroup_tasks_start':
/scratch/sfr/next/kernel/cgroup.c:2107: warning: unused variable 'i'

Introduced in commit cc31edceee04a7b87f2be48f9489ebb72d264844 "cgroups:
convert tasks file to use a seq_file with shared pid array".

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 kernel/cgroup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 046c160..35eebd5 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -2104,7 +2104,7 @@ static void *cgroup_tasks_start(struct seq_file *s, loff_t *pos)
 	down_read(&cgrp->pids_mutex);
 	if (pid) {
 		int end = cgrp->pids_length;
-		int i;
+
 		while (index < end) {
 			int mid = (index + end) / 2;
 			if (cgrp->tasks_pids[mid] == pid) {
-- 
1.5.6.5

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/