[PATCH][RESEND] tracing: fix a build error on alpha

[PATCH][RESEND] tracing: fix a build error on alpha

[Frederic Weisbecker]

When tracing is enabled, some arch have included <linux/irqflags.h>
on their <asm/system.h> but others like alpha or m68k don't.

Build error on alpha:

kernel/trace/trace.c: In function 'tracing_cpumask_write':
kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable'
kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable'

Tested on Alpha through a cross-compiler (should correct a similar issue on m68k).

Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 306e433..c09493e 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -34,6 +34,7 @@
 
 #include <linux/stacktrace.h>
 #include <linux/ring_buffer.h>
+#include <linux/irqflags.h>
 
 #include "trace.h"
 

Re: [PATCH][RESEND] tracing: fix a build error on alpha

[Ingo Molnar]

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> When tracing is enabled, some arch have included <linux/irqflags.h>
> on their <asm/system.h> but others like alpha or m68k don't.
> 
> Build error on alpha:
> 
> kernel/trace/trace.c: In function 'tracing_cpumask_write':
> kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable'
> kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable'
> 
> Tested on Alpha through a cross-compiler (should correct a similar issue on m68k).
> 
> Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>

applied to tip/tracing/urgent, thanks Frederic!

	Ingo

Re: [PATCH][RESEND] tracing: fix a build error on alpha

[Alexey Dobriyan]

On Tue, Oct 28, 2008 at 11:43 AM, Frederic Weisbecker
<fweisbec@gmail.com> wrote:
> +#include <linux/irqflags.h>

Already fixed.

Re: [PATCH][RESEND] tracing: fix a build error on alpha

[Ingo Molnar]

* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Tue, Oct 28, 2008 at 11:43 AM, Frederic Weisbecker
> <fweisbec@gmail.com> wrote:
> > +#include <linux/irqflags.h>
> 
> Already fixed.

Note that it's already fixed because the patch you are replying to 
(and which was sent 16 days ago) is already upstream:

  21798a8: tracing: fix a build error on alpha

	Ingo

Re: [PATCH][RESEND] tracing: fix a build error on alpha

[Frédéric Weisbecker]

2008/11/13 Alexey Dobriyan <adobriyan@gmail.com>:
> On Tue, Oct 28, 2008 at 11:43 AM, Frederic Weisbecker
> <fweisbec@gmail.com> wrote:
>> +#include <linux/irqflags.h>
>
> Already fixed.
>

And you were even put on Reported-by tag...