* [PATCH] x86: always select SWIOTLB on x86_64
@ 2008-11-18 11:44 Joerg Roedel
2008-11-18 13:51 ` Ingo Molnar
2008-11-19 5:41 ` FUJITA Tomonori
0 siblings, 2 replies; 3+ messages in thread
From: Joerg Roedel @ 2008-11-18 11:44 UTC (permalink / raw)
To: Ingo Molnar, Thomas Gleixner
Cc: linux-kernel, iommu, Joerg Roedel, hawk, stable
Impact: fixes korg bugzilla 11980
A kernel for a 64bit x86 system should always contain the swiotlb code
in case it is booted on a machine without any hardware IOMMU supported
by the kernel and more than 4GB of RAM. This patch changes Kconfig to
always compile swiotlb into the kernel for x86_64.
Cc: hawk@pld-linux.org
Cc: stable@kernel.org
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
arch/x86/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 93224b5..669c6d5 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -566,7 +566,7 @@ config AMD_IOMMU
# need this always selected by IOMMU for the VIA workaround
config SWIOTLB
- bool
+ def_bool y if X86_64
help
Support for software bounce buffers used on x86-64 systems
which don't have a hardware IOMMU (e.g. the current generation
--
1.5.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: always select SWIOTLB on x86_64
2008-11-18 11:44 [PATCH] x86: always select SWIOTLB on x86_64 Joerg Roedel
@ 2008-11-18 13:51 ` Ingo Molnar
2008-11-19 5:41 ` FUJITA Tomonori
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-11-18 13:51 UTC (permalink / raw)
To: Joerg Roedel
Cc: Ingo Molnar, Thomas Gleixner, linux-kernel, iommu, hawk, stable
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> Impact: fixes korg bugzilla 11980
>
> A kernel for a 64bit x86 system should always contain the swiotlb code
> in case it is booted on a machine without any hardware IOMMU supported
> by the kernel and more than 4GB of RAM. This patch changes Kconfig to
> always compile swiotlb into the kernel for x86_64.
>
> Cc: hawk@pld-linux.org
> Cc: stable@kernel.org
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
> arch/x86/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
applied to tip/x86/iommu, thanks Joerg!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: always select SWIOTLB on x86_64
2008-11-18 11:44 [PATCH] x86: always select SWIOTLB on x86_64 Joerg Roedel
2008-11-18 13:51 ` Ingo Molnar
@ 2008-11-19 5:41 ` FUJITA Tomonori
1 sibling, 0 replies; 3+ messages in thread
From: FUJITA Tomonori @ 2008-11-19 5:41 UTC (permalink / raw)
To: joerg.roedel; +Cc: mingo, tglx, linux-kernel, iommu, hawk, stable
On Tue, 18 Nov 2008 12:44:21 +0100
Joerg Roedel <joerg.roedel@amd.com> wrote:
> Impact: fixes korg bugzilla 11980
>
> A kernel for a 64bit x86 system should always contain the swiotlb code
> in case it is booted on a machine without any hardware IOMMU supported
> by the kernel and more than 4GB of RAM. This patch changes Kconfig to
> always compile swiotlb into the kernel for x86_64.
Yeah, as I wrote in a different thread, I think that it makes sense to
enable SWIOTLB at all times:
http://marc.info/?l=linux-kernel&m=122593287501949&w=2
An option asking an user if he has more than 4GB RAM or not, doesn't
make sense much.
BTW, you can also remove the help description, right?
> ---
> arch/x86/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 93224b5..669c6d5 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -566,7 +566,7 @@ config AMD_IOMMU
>
> # need this always selected by IOMMU for the VIA workaround
> config SWIOTLB
> - bool
> + def_bool y if X86_64
> help
> Support for software bounce buffers used on x86-64 systems
> which don't have a hardware IOMMU (e.g. the current generation
> --
> 1.5.6.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-19 5:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-18 11:44 [PATCH] x86: always select SWIOTLB on x86_64 Joerg Roedel
2008-11-18 13:51 ` Ingo Molnar
2008-11-19 5:41 ` FUJITA Tomonori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).