[git pull] device-mapper patches for 2.6.28

[git pull] device-mapper patches for 2.6.28

[Alasdair G Kergon]

Please pull from:

  master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git

to get the following device-mapper patches for 2.6.28:
 
Alasdair G Kergon (2):
      dm crypt: remove inc_pending from write_io_submit
      dm: detect lost queue

Benjamin Marzinski (1):
      dm mpath: use more error codes

Jonathan Brassow (1):
      dm raid1: kcopyd should stop on error if errors handled

Kiyoshi Ueda (1):
      dm mpath: remove is_active from struct dm_path

Mikulas Patocka (6):
      dm exception store: introduce area_location function
      dm exception store: use chunk_t for_areas
      dm: export struct dm_dev
      dm: publish dm_get_mapinfo
      dm: publish dm_table_unplug_all
      dm: publish dm_vcalloc

Milan Broz (7):
      dm crypt: tidy inc pending
      dm crypt: tidy crypt alloc
      dm crypt: tidy write loop pending
      dm crypt: move dec_pending on error into write_io_submit
      dm crypt: fix async inc_pending
      dm crypt: tidy ctx pending
      dm crypt: avoid unnecessary wait when splitting bio

 drivers/md/dm-crypt.c           |  109 +++++++++++++++++++++++---------------
 drivers/md/dm-exception-store.c |   29 +++++++----
 drivers/md/dm-ioctl.c           |    4 +-
 drivers/md/dm-mpath.c           |   35 +++++++------
 drivers/md/dm-mpath.h           |    2 -
 drivers/md/dm-raid1.c           |    4 +-
 drivers/md/dm-table.c           |   97 ++++++++++++++++++++++------------
 drivers/md/dm.h                 |   10 +---
 include/linux/device-mapper.h   |   18 ++++++-
 9 files changed, 190 insertions(+), 118 deletions(-)

Alasdair
-- 
agk@redhat.com

[git pull] device-mapper patches for 2.6.29

[Alasdair G Kergon]

Please pull from:

  master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git

to get the following device-mapper patches for 2.6.29:
 
Alasdair G Kergon (2):
      dm mpath: move trigger_event to system workqueue
      dm snapshot: split out exception store implementations

Andi Kleen (1):
      dm: support barriers on simple devices

Cheng Renquan (2):
      dm target: use module refcount directly
      dm target: remove struct tt_internal

Jonathan Brassow (4):
      dm raid1: fix error count
      dm snapshot: separate out exception store interface
      dm snapshot: rename struct exception_store
      dm snapshot: extend exception store functions

Kiyoshi Ueda (2):
      dm request: add caches
      dm request: extend target interface

Mikulas Patocka (4):
      dm table: drop reference at unbind
      dm snapshot: change yield to msleep
      dm: consolidate target deregistration error handling
      dm table: rework reference counting

Milan Broz (4):
      dm log: move region_size validation
      dm log: ensure log bitmap fits on log device
      dm ioctl: allow dm_copy_name_and_uuid to return only one field
      dm: add name and uuid to sysfs

Takahiro Yasui (2):
      dm log: fix dm_io_client leak on error paths
      dm log: avoid reinitialising io_req on every operation

 drivers/md/Makefile             |    5 +-
 drivers/md/dm-crypt.c           |    6 +-
 drivers/md/dm-delay.c           |    6 +-
 drivers/md/dm-exception-store.c |  749 +--------------------------------------
 drivers/md/dm-exception-store.h |  148 ++++++++
 drivers/md/dm-ioctl.c           |   16 +-
 drivers/md/dm-linear.c          |    6 +-
 drivers/md/dm-log.c             |   40 ++-
 drivers/md/dm-mpath.c           |   14 +-
 drivers/md/dm-raid1.c           |   24 +-
 drivers/md/dm-snap-persistent.c |  704 ++++++++++++++++++++++++++++++++++++
 drivers/md/dm-snap-transient.c  |   98 +++++
 drivers/md/dm-snap.c            |   48 ++-
 drivers/md/dm-snap.h            |  129 +-------
 drivers/md/dm-stripe.c          |    4 +-
 drivers/md/dm-sysfs.c           |   99 +++++
 drivers/md/dm-table.c           |   47 +++-
 drivers/md/dm-target.c          |  111 ++----
 drivers/md/dm-zero.c            |    5 +-
 drivers/md/dm.c                 |  101 ++++--
 drivers/md/dm.h                 |   12 +-
 include/linux/device-mapper.h   |   31 ++-
 22 files changed, 1352 insertions(+), 1051 deletions(-)
 create mode 100644 drivers/md/dm-exception-store.h
 create mode 100644 drivers/md/dm-snap-persistent.c
 create mode 100644 drivers/md/dm-snap-transient.c
 create mode 100644 drivers/md/dm-sysfs.c

Alasdair
-- 
agk@redhat.com

Re: [git pull] device-mapper patches for 2.6.29

[Linus Torvalds]

On Mon, 5 Jan 2009, Alasdair G Kergon wrote:
>
> Please pull from:
> 
>   master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git
> 
> to get the following device-mapper patches for 2.6.29:

Oh no, this is totally broken, and doesn't compile even with my fairly 
minimal install:

  drivers/md/dm-target.c: In function ‘dm_unregister_target’:
  drivers/md/dm-target.c:106: error: implicit declaration of function ‘module_refcount’

Not pulled.

		Linus

Re: [git pull] device-mapper patches for 2.6.29

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Hi Alasdair.

On Mon, 5 Jan 2009 18:51:00 -0800 (PST) Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> Oh no, this is totally broken, and doesn't compile even with my fairly 
> minimal install:
> 
>   drivers/md/dm-target.c: In function ‘dm_unregister_target’:
>   drivers/md/dm-target.c:106: error: implicit declaration of function ‘module_refcount’

This is from a patch added to linux-next only yesterday and was
reported by Randy Dunlap from his overnight build testing.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [dm-devel] Re: [git pull] device-mapper patches for 2.6.29

[Alasdair G Kergon]

On Mon, Jan 05, 2009 at 06:51:00PM -0800, Linus Torvalds wrote:
> On Mon, 5 Jan 2009, Alasdair G Kergon wrote:
> > Please pull from:
> >   master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git
> > to get the following device-mapper patches for 2.6.29:
> Oh no, this is totally broken, and doesn't compile even with my fairly 
> minimal install:
>   drivers/md/dm-target.c: In function ‘dm_unregister_target’:
>   drivers/md/dm-target.c:106: error: implicit declaration of function ‘module_refcount’
 
Missing an ifdef:-(  Sorry about that.  Better drop those two patches for now
then.

Please pull from:
     
  master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git
     
to get the following device-mapper patches for 2.6.29:

Alasdair G Kergon (2):
      dm mpath: move trigger_event to system workqueue
      dm snapshot: split out exception store implementations

Andi Kleen (1):
      dm: support barriers on simple devices

Jonathan Brassow (4):
      dm raid1: fix error count
      dm snapshot: separate out exception store interface
      dm snapshot: rename struct exception_store
      dm snapshot: extend exception store functions

Kiyoshi Ueda (2):
      dm request: add caches
      dm request: extend target interface

Mikulas Patocka (4):
      dm table: drop reference at unbind
      dm snapshot: change yield to msleep
      dm: consolidate target deregistration error handling
      dm table: rework reference counting

Milan Broz (4):
      dm log: move region_size validation
      dm log: ensure log bitmap fits on log device
      dm ioctl: allow dm_copy_name_and_uuid to return only one field
      dm: add name and uuid to sysfs

Takahiro Yasui (2):
      dm log: fix dm_io_client leak on error paths
      dm log: avoid reinitialising io_req on every operation

 drivers/md/Makefile             |    5 +-
 drivers/md/dm-crypt.c           |    6 +-
 drivers/md/dm-delay.c           |    6 +-
 drivers/md/dm-exception-store.c |  749 +--------------------------------------
 drivers/md/dm-exception-store.h |  148 ++++++++
 drivers/md/dm-ioctl.c           |   16 +-
 drivers/md/dm-linear.c          |    6 +-
 drivers/md/dm-log.c             |   40 ++-
 drivers/md/dm-mpath.c           |   14 +-
 drivers/md/dm-raid1.c           |   24 +-
 drivers/md/dm-snap-persistent.c |  704 ++++++++++++++++++++++++++++++++++++
 drivers/md/dm-snap-transient.c  |   98 +++++
 drivers/md/dm-snap.c            |   48 ++-
 drivers/md/dm-snap.h            |  129 +-------
 drivers/md/dm-stripe.c          |    4 +-
 drivers/md/dm-sysfs.c           |   99 +++++
 drivers/md/dm-table.c           |   47 +++-
 drivers/md/dm-target.c          |   15 +-
 drivers/md/dm-zero.c            |    5 +-
 drivers/md/dm.c                 |  101 ++++--
 drivers/md/dm.h                 |   10 +
 include/linux/device-mapper.h   |   28 ++-
 22 files changed, 1319 insertions(+), 983 deletions(-)
 create mode 100644 drivers/md/dm-exception-store.h
 create mode 100644 drivers/md/dm-snap-persistent.c
 create mode 100644 drivers/md/dm-snap-transient.c
 create mode 100644 drivers/md/dm-sysfs.c

Alasdair
-- 
agk@redhat.com

Re: [git pull] device-mapper patches for 2.6.29

[Cheng Renquan (程任全)]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1038 bytes --]

2009/1/6 Linus Torvalds <torvalds@linux-foundation.org>:>>> On Mon, 5 Jan 2009, Alasdair G Kergon wrote:>>>> Please pull from:>>>>   master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git>>>> to get the following device-mapper patches for 2.6.29:>> Oh no, this is totally broken, and doesn't compile even with my fairly> minimal install:>>  drivers/md/dm-target.c: In function 'dm_unregister_target':>  drivers/md/dm-target.c:106: error: implicit declaration of function 'module_refcount'>> Not pulled.>>                Linus>
That's my fault, module_refcount can only be used ifCONFIG_MODULE_UNLOAD defined according to <linux/module.h>,
So now maybe we can add a null macro to module_refcount ifCONFIG_MODULE_UNLOAD undefined?
-- Cheng Renquan (程任全), Shenzhen, ChinaPaula Poundstone  - "I don't have a bank account because I don't knowmy mother's maiden name."ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [git pull] device-mapper patches for 2.6.29

[Alasdair G Kergon]

On Tue, Jan 06, 2009 at 11:15:58AM +0800, Cheng Renquan (程任全) wrote:
> So now maybe we can add a null macro to module_refcount if
> CONFIG_MODULE_UNLOAD undefined?
 
Do we even need the test at all?

Alasdair
-- 
agk@redhat.com

Re: [git pull] device-mapper patches for 2.6.29

[Cheng Renquan (程任全)]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 726 bytes --]

On Tue, Jan 6, 2009 at 11:21 AM, Alasdair G Kergon <agk@redhat.com> wrote:> On Tue, Jan 06, 2009 at 11:15:58AM +0800, Cheng Renquan (程任全) wrote:>> So now maybe we can add a null macro to module_refcount if>> CONFIG_MODULE_UNLOAD undefined?>> Do we even need the test at all?
So you mean add "#ifdef CONFIG_MODULE_UNLOAD ..." to dm-target.c? Ican do that, but I really don't know a better solution withoutconditional compiling?
>> Alasdair> --> agk@redhat.com
-- Cheng Renquan, Shenzhen, ChinaEddie Izzard  - "I grew up in Europe, where the history comes from."ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [dm-devel] Re: [git pull] device-mapper patches for 2.6.29

[Alasdair G Kergon]

On Tue, Jan 06, 2009 at 11:32:51AM +0800, Cheng Renquan (程任全) wrote:
> On Tue, Jan 6, 2009 at 11:21 AM, Alasdair G Kergon <agk@redhat.com> wrote:
> > On Tue, Jan 06, 2009 at 11:15:58AM +0800, Cheng Renquan (程任全) wrote:
> >> So now maybe we can add a null macro to module_refcount if
> >> CONFIG_MODULE_UNLOAD undefined?
> > Do we even need the test at all?
 
> So you mean add "#ifdef CONFIG_MODULE_UNLOAD ..." to dm-target.c? I
> can do that, but I really don't know a better solution without
> conditional compiling?
 
I mean under what set of circumstances could the test of the module refcount
here fail, and if the test was simply removed are there any cases where that
would matter?

Alasdair
-- 
agk@redhat.com

Re: [git pull] device-mapper patches for 2.6.29

[Stefan Richter]

Cheng Renquan (程任全) wrote:
> On Tue, Jan 6, 2009 at 11:21 AM, Alasdair G Kergon <agk@redhat.com> wrote:
>> On Tue, Jan 06, 2009 at 11:15:58AM +0800, Cheng Renquan (程任全) wrote:
>>> So now maybe we can add a null macro to module_refcount if
>>> CONFIG_MODULE_UNLOAD undefined?
>>
>> Do we even need the test at all?
> 
> So you mean add "#ifdef CONFIG_MODULE_UNLOAD ..." to dm-target.c? I
> can do that, but I really don't know a better solution without
> conditional compiling?

The fact that module_refcount may be undefined is an indicator that this
is not an API for general use.

Why are you wanting to peek into the reference count of a module?
Shouldn't you have everything covered by properly recounting all your
data objects?  (Preferably via the kref API.)
-- 
Stefan Richter
-=====-==--= ---= --==-
http://arcgraph.de/sr/