* gpio_keys: request_irq with level triggered flags
@ 2009-01-12 11:38 Trilok Soni
2009-01-12 11:59 ` Ben Dooks
0 siblings, 1 reply; 2+ messages in thread
From: Trilok Soni @ 2009-01-12 11:38 UTC (permalink / raw)
To: dtor; +Cc: David Brownell, linux-kernel
Hi Dmitry,
>From the gpio_keys.c, I can see that request_irq is assuming all the
gpio line interrupts to be edge triggered one, but what if we have
level triggered interrupts? Doesn't this flags need to come from
platform data hooks too? So, that we can specify either
(IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING ) or (IRQF_TRIGGER_HIGH |
IRQF_TRIGGER_LOW) based on the platform data?
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: gpio_keys: request_irq with level triggered flags
2009-01-12 11:38 gpio_keys: request_irq with level triggered flags Trilok Soni
@ 2009-01-12 11:59 ` Ben Dooks
0 siblings, 0 replies; 2+ messages in thread
From: Ben Dooks @ 2009-01-12 11:59 UTC (permalink / raw)
To: Trilok Soni; +Cc: dtor, David Brownell, linux-kernel
On Mon, Jan 12, 2009 at 05:08:44PM +0530, Trilok Soni wrote:
> Hi Dmitry,
>
> >From the gpio_keys.c, I can see that request_irq is assuming all the
> gpio line interrupts to be edge triggered one, but what if we have
> level triggered interrupts? Doesn't this flags need to come from
> platform data hooks too? So, that we can specify either
> (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING ) or (IRQF_TRIGGER_HIGH |
> IRQF_TRIGGER_LOW) based on the platform data?
If you are going to change to level triggered IRQs, any active IRQs
will have to be masked until the key is release, otherwise the IRQ
handler will keep being re-entered whilst the IRQ is active.
>
> --
> ---Trilok Soni
> http://triloksoni.wordpress.com
> http://www.linkedin.com/in/triloksoni
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-12 12:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-12 11:38 gpio_keys: request_irq with level triggered flags Trilok Soni
2009-01-12 11:59 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).