* [PATCH] mfd: Mark WM835x USB_SLV_500MA bit as accessible
@ 2009-01-14 14:55 Mark Brown
2009-01-16 0:02 ` Andrew Morton
2009-02-06 13:56 ` Samuel Ortiz
0 siblings, 2 replies; 4+ messages in thread
From: Mark Brown @ 2009-01-14 14:55 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel, Mark Brown
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/wm8350-regmap.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/wm8350-regmap.c b/drivers/mfd/wm8350-regmap.c
index 68887b8..9a4cc95 100644
--- a/drivers/mfd/wm8350-regmap.c
+++ b/drivers/mfd/wm8350-regmap.c
@@ -3188,7 +3188,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = {
{ 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */
{ 0x0000, 0x0000, 0x0000 }, /* R2 */
{ 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */
- { 0xFCF7, 0xFCF7, 0xF800 }, /* R4 - System Control 2 */
+ { 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */
{ 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */
{ 0xFB0E, 0xFB0E, 0x0000 }, /* R6 - Interface Control */
{ 0x0000, 0x0000, 0x0000 }, /* R7 */
--
1.5.6.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: Mark WM835x USB_SLV_500MA bit as accessible
2009-01-14 14:55 [PATCH] mfd: Mark WM835x USB_SLV_500MA bit as accessible Mark Brown
@ 2009-01-16 0:02 ` Andrew Morton
2009-01-16 1:20 ` Mark Brown
2009-02-06 13:56 ` Samuel Ortiz
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2009-01-16 0:02 UTC (permalink / raw)
To: Mark Brown; +Cc: sameo, linux-kernel, broonie
On Wed, 14 Jan 2009 14:55:01 +0000
Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm8350-regmap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/wm8350-regmap.c b/drivers/mfd/wm8350-regmap.c
> index 68887b8..9a4cc95 100644
> --- a/drivers/mfd/wm8350-regmap.c
> +++ b/drivers/mfd/wm8350-regmap.c
> @@ -3188,7 +3188,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = {
> { 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */
> { 0x0000, 0x0000, 0x0000 }, /* R2 */
> { 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */
> - { 0xFCF7, 0xFCF7, 0xF800 }, /* R4 - System Control 2 */
> + { 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */
> { 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */
> { 0xFB0E, 0xFB0E, 0x0000 }, /* R6 - Interface Control */
> { 0x0000, 0x0000, 0x0000 }, /* R7 */
Why?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: Mark WM835x USB_SLV_500MA bit as accessible
2009-01-16 0:02 ` Andrew Morton
@ 2009-01-16 1:20 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2009-01-16 1:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: sameo, linux-kernel
On Thu, Jan 15, 2009 at 04:02:00PM -0800, Andrew Morton wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > - { 0xFCF7, 0xFCF7, 0xF800 }, /* R4 - System Control 2 */
> > + { 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */
> Why?
The code is out of sync with the silicon - this table provides the
driver with a map of what access is provided in hardware, the fact that
this was masked off is a bug in the driver.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: Mark WM835x USB_SLV_500MA bit as accessible
2009-01-14 14:55 [PATCH] mfd: Mark WM835x USB_SLV_500MA bit as accessible Mark Brown
2009-01-16 0:02 ` Andrew Morton
@ 2009-02-06 13:56 ` Samuel Ortiz
1 sibling, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2009-02-06 13:56 UTC (permalink / raw)
To: Mark Brown; +Cc: linux-kernel
On Wed, Jan 14, 2009 at 02:55:01PM +0000, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mfd/wm8350-regmap.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/wm8350-regmap.c b/drivers/mfd/wm8350-regmap.c
> index 68887b8..9a4cc95 100644
> --- a/drivers/mfd/wm8350-regmap.c
> +++ b/drivers/mfd/wm8350-regmap.c
> @@ -3188,7 +3188,7 @@ const struct wm8350_reg_access wm8350_reg_io_map[] = {
> { 0x7CFF, 0x0C00, 0x7FFF }, /* R1 - ID */
> { 0x0000, 0x0000, 0x0000 }, /* R2 */
> { 0xBE3B, 0xBE3B, 0x8000 }, /* R3 - System Control 1 */
> - { 0xFCF7, 0xFCF7, 0xF800 }, /* R4 - System Control 2 */
> + { 0xFEF7, 0xFEF7, 0xF800 }, /* R4 - System Control 2 */
> { 0x80FF, 0x80FF, 0x8000 }, /* R5 - System Hibernate */
> { 0xFB0E, 0xFB0E, 0x0000 }, /* R6 - Interface Control */
> { 0x0000, 0x0000, 0x0000 }, /* R7 */
> --
> 1.5.6.5
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-02-06 13:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-14 14:55 [PATCH] mfd: Mark WM835x USB_SLV_500MA bit as accessible Mark Brown
2009-01-16 0:02 ` Andrew Morton
2009-01-16 1:20 ` Mark Brown
2009-02-06 13:56 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).