[PATCH] tags: fix config symbols generation

[PATCH] tags: fix config symbols generation

[Alexey Dobriyan]

commit 4f628248a578585472e19e4cba2c604643af8c6c aka
"kbuild: reintroduce ALLSOURCE_ARCHS support for tags/cscope"
breaks tags generation for Kconfig symbols.

Steps to reproduce:

	make tags
	vi -t PROC_FS

It should jump to 'config PROC_FS' line.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 scripts/tags.sh |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -76,7 +76,10 @@ all_sources()
 
 all_kconfigs()
 {
-	find_sources $ALLSOURCE_ARCHS 'Kconfig*'
+	for arch in $ALLSOURCE_ARCHS; do
+		find_sources $arch 'Kconfig*'
+	done
+	find_other_sources 'Kconfig*'
 }
 
 all_defconfigs()

Re: [PATCH] tags: fix config symbols generation

[Pete Wyckoff]

adobriyan@gmail.com wrote on Thu, 29 Jan 2009 13:26 +0300:
> commit 4f628248a578585472e19e4cba2c604643af8c6c aka
> "kbuild: reintroduce ALLSOURCE_ARCHS support for tags/cscope"
> breaks tags generation for Kconfig symbols.
> 
> Steps to reproduce:
> 
> 	make tags
> 	vi -t PROC_FS
> 
> It should jump to 'config PROC_FS' line.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  scripts/tags.sh |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -76,7 +76,10 @@ all_sources()
>  
>  all_kconfigs()
>  {
> -	find_sources $ALLSOURCE_ARCHS 'Kconfig*'
> +	for arch in $ALLSOURCE_ARCHS; do
> +		find_sources $arch 'Kconfig*'
> +	done
> +	find_other_sources 'Kconfig*'
>  }
>  
>  all_defconfigs()

Yes, this is necessary.  It fixes the problem introduced by
4f628248a578585472e19e4cba2c604643af8c6c (kbuild: reintroduce
ALLSOURCE_ARCHS support for tags/cscope).

Tested-by: Pete Wyckoff <pw@padd.com>

Re: [PATCH] tags: fix config symbols generation

[Sam Ravnborg]

On Fri, Feb 06, 2009 at 07:08:58AM -0800, Pete Wyckoff wrote:
> adobriyan@gmail.com wrote on Thu, 29 Jan 2009 13:26 +0300:
> > commit 4f628248a578585472e19e4cba2c604643af8c6c aka
> > "kbuild: reintroduce ALLSOURCE_ARCHS support for tags/cscope"
> > breaks tags generation for Kconfig symbols.
> > 
> > Steps to reproduce:
> > 
> > 	make tags
> > 	vi -t PROC_FS
> > 
> > It should jump to 'config PROC_FS' line.
> > 
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > ---
> > 
> >  scripts/tags.sh |    5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > --- a/scripts/tags.sh
> > +++ b/scripts/tags.sh
> > @@ -76,7 +76,10 @@ all_sources()
> >  
> >  all_kconfigs()
> >  {
> > -	find_sources $ALLSOURCE_ARCHS 'Kconfig*'
> > +	for arch in $ALLSOURCE_ARCHS; do
> > +		find_sources $arch 'Kconfig*'
> > +	done
> > +	find_other_sources 'Kconfig*'
> >  }
> >  
> >  all_defconfigs()
> 
> Yes, this is necessary.  It fixes the problem introduced by
> 4f628248a578585472e19e4cba2c604643af8c6c (kbuild: reintroduce
> ALLSOURCE_ARCHS support for tags/cscope).
> 
> Tested-by: Pete Wyckoff <pw@padd.com>

Thanks for testing.
I'm heading for vacation in a few hours and has been busy at job due to this.
I will add this (and other pending stuff) to my kbuild-fixes.git tree
when I'm back.

	Sam