linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [KBUILD] add symbol value to help find the real depend
@ 2009-02-18  8:13 Cheng Renquan
  2009-02-21  6:12 ` Randy Dunlap
       [not found] ` <435196707.27641@eyou.net>
  0 siblings, 2 replies; 4+ messages in thread
From: Cheng Renquan @ 2009-02-18  8:13 UTC (permalink / raw)
  To: Sam Ravnborg, Roman Zippel; +Cc: linux-kbuild, linux-kernel, Cheng Renquan

From: Cheng Renquan <chengrq@uit.com.cn>

kbuild-menuconfig-display-depend-value.patch

Sometimes when configuring need to disable some unused item, but the item is
selected by many other items, it's hard to find the real dependency which
selected it, This patch add every symbol's value accompanied to make it
possible to find the real dependency easily.

An example is CONFIG_RFKILL,

  ---------------------- RF switch subsystem support ----------------------
  | CONFIG_RFKILL:                                                        |
  |                                                                       |
  | Say Y here if you want to have control over RF switches               |
  | found on many WiFi and Bluetooth cards.                               |
  |                                                                       |
  | To compile this driver as a module, choose M here: the                |
  | module will be called rfkill.                                         |
  |                                                                       |
  | Symbol: RFKILL [=m]                                                   |
  | Prompt: RF switch subsystem support                                   |
  |   Defined at net/rfkill/Kconfig:4                                     |
  |   Depends on: NET [=y]                                                |
  |   Location:                                                           |
  |     -> Networking support (NET [=y])                                  |
  |   Selected by: IWLCORE [=n] && NETDEVICES [=y] && !S390 [=S390] && PC |
  |                                                                       |
  ----------------------------------------------------------------( 99%)---

Signed-off-by: Cheng Renquan <chengrq@uit.com.cn>

---

Index: linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
===================================================================
--- linux-2.6.29-rc5-lio.orig/scripts/kconfig/expr.c
+++ linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
@@ -1098,6 +1098,9 @@ void expr_fprint(struct expr *e, FILE *o
 static void expr_print_gstr_helper(void *data, struct symbol *sym, const char *str)
 {
 	str_append((struct gstr*)data, str);
+	if (sym)
+		str_printf((struct gstr *)data, " [=%s]",
+				sym_get_string_value(sym));
 }
 
 void expr_gstr_print(struct expr *e, struct gstr *gs)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] [KBUILD] add symbol value to help find the real depend
  2009-02-18  8:13 [PATCH] [KBUILD] add symbol value to help find the real depend Cheng Renquan
@ 2009-02-21  6:12 ` Randy Dunlap
       [not found] ` <435196707.27641@eyou.net>
  1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2009-02-21  6:12 UTC (permalink / raw)
  To: Cheng Renquan
  Cc: Sam Ravnborg, Roman Zippel, linux-kbuild, linux-kernel, Cheng Renquan

On Wed, 18 Feb 2009 16:13:45 +0800 Cheng Renquan wrote:

> From: Cheng Renquan <chengrq@uit.com.cn>
> 
> kbuild-menuconfig-display-depend-value.patch
> 
> Sometimes when configuring need to disable some unused item, but the item is
> selected by many other items, it's hard to find the real dependency which
> selected it, This patch add every symbol's value accompanied to make it
> possible to find the real dependency easily.
> 
> An example is CONFIG_RFKILL,
> 
>   ---------------------- RF switch subsystem support ----------------------
>   | CONFIG_RFKILL:                                                        |
>   |                                                                       |
>   | Say Y here if you want to have control over RF switches               |
>   | found on many WiFi and Bluetooth cards.                               |
>   |                                                                       |
>   | To compile this driver as a module, choose M here: the                |
>   | module will be called rfkill.                                         |
>   |                                                                       |
>   | Symbol: RFKILL [=m]                                                   |
>   | Prompt: RF switch subsystem support                                   |
>   |   Defined at net/rfkill/Kconfig:4                                     |
>   |   Depends on: NET [=y]                                                |
>   |   Location:                                                           |
>   |     -> Networking support (NET [=y])                                  |
>   |   Selected by: IWLCORE [=n] && NETDEVICES [=y] && !S390 [=S390] && PC |
>   |                                                                       |
>   ----------------------------------------------------------------( 99%)---
> 
> Signed-off-by: Cheng Renquan <chengrq@uit.com.cn>
> 
> ---
> 
> Index: linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
> ===================================================================
> --- linux-2.6.29-rc5-lio.orig/scripts/kconfig/expr.c
> +++ linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
> @@ -1098,6 +1098,9 @@ void expr_fprint(struct expr *e, FILE *o
>  static void expr_print_gstr_helper(void *data, struct symbol *sym, const char *str)
>  {
>  	str_append((struct gstr*)data, str);
> +	if (sym)
> +		str_printf((struct gstr *)data, " [=%s]",
> +				sym_get_string_value(sym));
>  }
>  
>  void expr_gstr_print(struct expr *e, struct gstr *gs)
> --

Hi,

This looks good/helpful.  Can it be made to work with
gconfig & xconfig as well as menuconfig?

Thanks,
---
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] [KBUILD] add symbol value to help find the real depend
       [not found] ` <435196707.27641@eyou.net>
@ 2009-02-23 10:28   ` Cheng Renquan
  0 siblings, 0 replies; 4+ messages in thread
From: Cheng Renquan @ 2009-02-23 10:28 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Sam Ravnborg, Roman Zippel, linux-kbuild, linux-kernel

On Sat, Feb 21, 2009 at 2:12 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> Hi,
>
> This looks good/helpful.  Can it be made to work with
> gconfig & xconfig as well as menuconfig?

Patches for gconfig & xconfig are already in progress, please be
patient, I will post later. Thanks,

-- 
Cheng Renquan, Shenzhen, China
Henny Youngman  - "When I told my doctor I couldn't afford an
operation, he offered to touch-up my X-rays."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] [KBUILD] add symbol value to help find the real depend
@ 2009-02-18  7:57 Cheng Renquan
  0 siblings, 0 replies; 4+ messages in thread
From: Cheng Renquan @ 2009-02-18  7:57 UTC (permalink / raw)
  To: Sam Ravnborg, Roman Zippel; +Cc: linux-kbuild, linux-kernel, Cheng Renquan

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2496 bytes --]

From: Cheng Renquan <chengrq@uit.com.cn>

kbuild-menuconfig-display-depend-value.patch

  ©°©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤ RF switch subsystem support ©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©´   
  ©¦ CONFIG_RFKILL:                                                        ©¦   
  ©¦                                                                       ©¦   
  ©¦ Say Y here if you want to have control over RF switches               ©¦   
  ©¦ found on many WiFi and Bluetooth cards.                               ©¦   
  ©¦                                                                       ©¦   
  ©¦ To compile this driver as a module, choose M here: the                ©¦   
  ©¦ module will be called rfkill.                                         ©¦   
  ©¦                                                                       ©¦   
  ©¦ Symbol: RFKILL [=m]                                                   ©¦   
  ©¦ Prompt: RF switch subsystem support                                   ©¦   
  ©¦   Defined at net/rfkill/Kconfig:4                                     ©¦   
  ©¦   Depends on: NET [=y]                                                ©¦   
  ©¦   Location:                                                           ©¦   
  ©¦     -> Networking support (NET [=y])                                  ©¦   
  ©¦   Selected by: IWLCORE [=n] && NETDEVICES [=y] && !S390 [=S390] && PC ©¦   
  ©¦                                                                       ©¦   
  ©À©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤( 99%)©¤©¤©È   
  ©¦                               < Exit >                                ©¦   
  ©¸©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¤©¼   

Signed-off-by: Cheng Renquan <chengrq@uit.com.cn>

---

Index: linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
===================================================================
--- linux-2.6.29-rc5-lio.orig/scripts/kconfig/expr.c
+++ linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
@@ -1098,6 +1098,8 @@ void expr_fprint(struct expr *e, FILE *o
 static void expr_print_gstr_helper(void *data, struct symbol *sym, const char *str)
 {
 	str_append((struct gstr*)data, str);
+	if (sym)
+		str_printf((struct gstr*)data, " [=%s]", sym_get_string_value(sym));
 }
 
 void expr_gstr_print(struct expr *e, struct gstr *gs)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-02-23 10:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-18  8:13 [PATCH] [KBUILD] add symbol value to help find the real depend Cheng Renquan
2009-02-21  6:12 ` Randy Dunlap
     [not found] ` <435196707.27641@eyou.net>
2009-02-23 10:28   ` Cheng Renquan
  -- strict thread matches above, loose matches on Subject: below --
2009-02-18  7:57 Cheng Renquan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).