* [PATCH 1/5] IPMI: Fix platform return check
@ 2009-03-03 15:18 Corey Minyard
0 siblings, 0 replies; only message in thread
From: Corey Minyard @ 2009-03-03 15:18 UTC (permalink / raw)
To: Andrew Morton, Linux Kernel; +Cc: OpenIPMI Developers
The wrong return value is being tested when allocating a platform
device in the IPMI SI code. Check the right value.
Signed-off-by: Corey Minyard <minyard@acm.org>
---
Index: linux-2.6.25/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux-2.6.25.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2.6.25/drivers/char/ipmi/ipmi_si_intf.c
@@ -2864,7 +2864,7 @@ static int try_smi_init(struct smi_info
*/
new_smi->pdev = platform_device_alloc("ipmi_si",
new_smi->intf_num);
- if (rv) {
+ if (!new_smi->pdev) {
printk(KERN_ERR
"ipmi_si_intf:"
" Unable to allocate platform device\n");
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-03-03 15:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-03 15:18 [PATCH 1/5] IPMI: Fix platform return check Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).