linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -tip] x86: fix undefined linking reference of nx_enabled for 64 bit
@ 2009-03-06 15:49 Jaswinder Singh Rajput
  2009-03-06 15:50 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Jaswinder Singh Rajput @ 2009-03-06 15:49 UTC (permalink / raw)
  To: Ingo Molnar, x86 maintainers, Andrew Morton, LKML

Subject: [PATCH] x86: fix undefined linking reference of nx_enabled for 64 bit

  LD      .tmp_vmlinux1
arch/x86/mm/built-in.o: In function `init_memory_mapping':
(.ref.text+0x73): undefined reference to `nx_enabled'
make: *** [.tmp_vmlinux1] Error 1

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
 arch/x86/mm/init.c    |    2 ++
 arch/x86/mm/init_32.c |    2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index acdfba8..9799a1c 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -49,6 +49,8 @@ static int __init noexec_setup(char *str)
 early_param("noexec", noexec_setup);
 #endif
 
+int nx_enabled;
+
 #ifdef CONFIG_X86_PAE
 static void __init set_nx(void)
 {
diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
index 26a135f..a8458b9 100644
--- a/arch/x86/mm/init_32.c
+++ b/arch/x86/mm/init_32.c
@@ -587,8 +587,6 @@ void zap_low_mappings(void)
 	flush_tlb_all();
 }
 
-int nx_enabled;
-
 pteval_t __supported_pte_mask __read_mostly = ~(_PAGE_NX | _PAGE_GLOBAL | _PAGE_IOMAP);
 EXPORT_SYMBOL_GPL(__supported_pte_mask);
 
-- 
1.6.0.6




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -tip] x86: fix undefined linking reference of nx_enabled for 64 bit
  2009-03-06 15:49 [PATCH -tip] x86: fix undefined linking reference of nx_enabled for 64 bit Jaswinder Singh Rajput
@ 2009-03-06 15:50 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-03-06 15:50 UTC (permalink / raw)
  To: Jaswinder Singh Rajput; +Cc: x86 maintainers, Andrew Morton, LKML


* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

> Subject: [PATCH] x86: fix undefined linking reference of nx_enabled for 64 bit
> 
>   LD      .tmp_vmlinux1
> arch/x86/mm/built-in.o: In function `init_memory_mapping':
> (.ref.text+0x73): undefined reference to `nx_enabled'
> make: *** [.tmp_vmlinux1] Error 1

yep - just fixed it and pushed out a new tip:master about 10 
minutes ago.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-06 15:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-06 15:49 [PATCH -tip] x86: fix undefined linking reference of nx_enabled for 64 bit Jaswinder Singh Rajput
2009-03-06 15:50 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).