linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Be able to build pmac driver without IDE built-in
@ 2009-03-19 17:41 Gilles Espinasse
  2009-03-23 20:12 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: Gilles Espinasse @ 2009-03-19 17:41 UTC (permalink / raw)
  To: sam; +Cc: linux-kernel, linux-kbuild

No reason to need IDE built-in to be able to compile pmac driver
Tested to work on 2.6.29-rc8 and 2.6.28.8 with ide and pmac as modules
inside an initramfs

 Signed-off-by: Gilles Espinasse <g.esp@free.fr>

--- linux-2.6.28/drivers/ide/Kconfig.old 2009-03-19 16:36:34.000000000 +0100
+++ linux-2.6.28/drivers/ide/Kconfig 2009-03-19 16:35:49.000000000 +0100
@@ -676,7 +676,7 @@
 # TODO: BLK_DEV_IDEDMA_PCI -> BLK_DEV_IDEDMA_SFF
 config BLK_DEV_IDE_PMAC
  tristate "PowerMac on-board IDE support"
- depends on PPC_PMAC && IDE=y
+ depends on PPC_PMAC && IDE
  select IDE_TIMINGS
  select BLK_DEV_IDEDMA_PCI
  help


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Be able to build pmac driver without IDE built-in
  2009-03-19 17:41 [PATCH] Be able to build pmac driver without IDE built-in Gilles Espinasse
@ 2009-03-23 20:12 ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-03-23 20:12 UTC (permalink / raw)
  To: Gilles Espinasse; +Cc: sam, linux-kernel, linux-kbuild, benh

On Thursday 19 March 2009, Gilles Espinasse wrote:
> No reason to need IDE built-in to be able to compile pmac driver
> Tested to work on 2.6.29-rc8 and 2.6.28.8 with ide and pmac as modules
> inside an initramfs
> 
>  Signed-off-by: Gilles Espinasse <g.esp@free.fr>

applied by hand (please check your mailer settings
as it seems to corrupt whitespaces)

> --- linux-2.6.28/drivers/ide/Kconfig.old 2009-03-19 16:36:34.000000000 +0100
> +++ linux-2.6.28/drivers/ide/Kconfig 2009-03-19 16:35:49.000000000 +0100
> @@ -676,7 +676,7 @@
>  # TODO: BLK_DEV_IDEDMA_PCI -> BLK_DEV_IDEDMA_SFF
>  config BLK_DEV_IDE_PMAC
>   tristate "PowerMac on-board IDE support"
> - depends on PPC_PMAC && IDE=y
> + depends on PPC_PMAC && IDE

IDE config options are covered by if IDE ... endif so no need to check
for IDE explicitly now (I cleaned this while applying the patch)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-23 20:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-19 17:41 [PATCH] Be able to build pmac driver without IDE built-in Gilles Espinasse
2009-03-23 20:12 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).