[patch 0/21] x86, ptrace, bts, hw-branch-tracer: fixes and cleanups

* [patch 0/21] x86, ptrace, bts, hw-branch-tracer: fixes and cleanups
@ 2009-03-31 12:42 Markus Metzger
  2009-03-31 23:39 ` Oleg Nesterov
  0 siblings, 1 reply; 6+ messages in thread
From: Markus Metzger @ 2009-03-31 12:42 UTC (permalink / raw)
  To: linux-kernel, mingo, tglx, hpa
  Cc: markus.t.metzger, markus.t.metzger, roland, eranian, oleg,
	juan.villacis, ak

Patches 1-6 fix a number of races when the traced task is currently running.

In the worst case, the kernel may crash since the cpu may continue
tracing after the trace buffer has already been freed.
This may happen when the tracing or traced task are killed.

The first 5 patches apply to .29 with the small preparation patch below.


Patches 7-11 fix problems with the hw-branch-tracer. It performs DS
operations in an on_each_cpu() context, which has interrupts disabled.
Patch 7 adds a _noirq version for most ds_ functions and separates
cpu and task tracing. It allows cpu tracing to be configured from any cpu.
This allows the hw-branch-tracer in patch 8 to remove the bad spinlock
and use simple for_each_online_cpu loops.
The remaining patches change the other DS users to use the new interface.

Patches 12-15 add more selftests, defer selftesting, and fix a bad check.

Patches 16-19 do some cleanups that have been requested from reviewers.

Patch 20 fixes a bug where the wrong qualifier was passed to a shared function
resulting in the bts configuration to be reset when a reset of the pebs
configuration had been requested.

Patch 21 adds support for Core i7.


Thanks to Oleg Nesterov for reviewing the first round of patches and
for pointing out several races!


Signed-off-by: Markus Metzger <markus.t.metzger@intel.com>
---

Index: linux-2.6.29/arch/x86/kernel/ds.c
===================================================================

--- linux-2.6.29.orig/arch/x86/kernel/ds.c	2009-03-31 11:56:21.000000000 +0200
+++ linux-2.6.29/arch/x86/kernel/ds.c	2009-03-31 11:57:38.000000000 +0200
@@ -78,8 +78,8 @@ struct bts_tracer {
 	struct ds_tracer ds;
 	/* the trace including the DS configuration */
 	struct bts_trace trace;
-	/* buffer overflow notification function */
-	bts_ovfl_callback_t ovfl;
+	/* Buffer overflow notification function: */
+	bts_ovfl_callback_t	ovfl;
 };
 
 struct pebs_tracer {
Index: linux-2.6.29/arch/x86/kernel/ptrace.c
===================================================================
--- linux-2.6.29.orig/arch/x86/kernel/ptrace.c	2009-03-31 11:56:21.000000000 +0200
+++ linux-2.6.29/arch/x86/kernel/ptrace.c	2009-03-31 11:56:24.000000000 +0200
@@ -21,6 +21,7 @@
 #include <linux/audit.h>
 #include <linux/seccomp.h>
 #include <linux/signal.h>
+#include <linux/ftrace.h>
 
 #include <asm/uaccess.h>
 #include <asm/pgtable.h>
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


^ permalink raw reply	[flat|nested] 6+ messages in thread