From: David Miller <davem@davemloft.net>
To: amluto@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Tell linkwatch about new interfaces
Date: Sat, 04 Apr 2009 17:05:39 -0700 (PDT) [thread overview]
Message-ID: <20090404.170539.148727646.davem@davemloft.net> (raw)
In-Reply-To: <cb0375e10904010840n1543a890w9039465d0f80ffcc@mail.gmail.com>
From: Andrew Lutomirski <amluto@gmail.com>
Date: Wed, 1 Apr 2009 11:40:06 -0400
> When a network driver registers a new interface, linkwatch will not notice,
> and hence not set the rfc2863 operstate, until netif_carrier_on gets called.
> If the new interface has no carrier when it is connected, then a status of
> "unknown" is reported to userspace, which confuses various tools
> (NetworkManager, for example).
>
> This fires a linkwatch event for all new interfaces, so that operstate
> gets set reasonably quickly.
>
> Signed-off-by: Andrew Lutomirski <amluto@gmail.com>
The default assumed state for a freshly registered network
device is that the link is up.
If that disagrees from reality, the driver should make the
appropriate netif_carrier_off() call.
I'm sure you'll find that the e1000 driver is not doing this
and that is what causes the bug you are seeing.
next prev parent reply other threads:[~2009-04-05 0:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 15:40 [PATCH 1/1] Tell linkwatch about new interfaces Andrew Lutomirski
2009-04-05 0:05 ` David Miller [this message]
2009-04-05 4:00 ` Andrew Lutomirski
2009-04-10 0:48 ` Brandeburg, Jesse
2009-04-11 15:46 ` Andrew Lutomirski
2009-04-13 23:22 ` David Miller
2009-04-14 7:43 ` Jeff Kirsher
2009-07-14 17:17 ` Sergio Luis
2009-07-14 18:33 ` David Miller
2009-07-14 18:37 ` Sergio Luis
2009-07-14 18:58 ` Andrew Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090404.170539.148727646.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amluto@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).