From: Andrew Lutomirski <amluto@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: eeeesti@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Tell linkwatch about new interfaces
Date: Tue, 14 Jul 2009 14:58:06 -0400 [thread overview]
Message-ID: <cb0375e10907141158l345742e3t1a252d1d1d0db526@mail.gmail.com> (raw)
In-Reply-To: <20090714.113348.155881037.davem@davemloft.net>
On Tue, Jul 14, 2009 at 2:33 PM, David Miller<davem@davemloft.net> wrote:
> From: Sergio Luis <eeeesti@gmail.com>
> Date: Tue, 14 Jul 2009 14:17:21 -0300
>
>> is this patch incorrect, though? with the linkwatch_fire_event() call,
>> the rfc2863 operstate will be set for everyone at device register
>> time.
>
> The issue is dumb drivers that do not manage their link state
> at all. We want them to always have their links up, from the
> moment they are registered.
Such dumb drivers still end up with bogus operstate.
>
> This is especially important for virtual devices.
$ ip link show lo
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 16436 qdisc noqueue state UNKNOWN
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
I've never noticed this causing a problem, but it seems a little
silly. Presumably lo should be "UP."
--Andy
>
prev parent reply other threads:[~2009-07-14 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 15:40 [PATCH 1/1] Tell linkwatch about new interfaces Andrew Lutomirski
2009-04-05 0:05 ` David Miller
2009-04-05 4:00 ` Andrew Lutomirski
2009-04-10 0:48 ` Brandeburg, Jesse
2009-04-11 15:46 ` Andrew Lutomirski
2009-04-13 23:22 ` David Miller
2009-04-14 7:43 ` Jeff Kirsher
2009-07-14 17:17 ` Sergio Luis
2009-07-14 18:33 ` David Miller
2009-07-14 18:37 ` Sergio Luis
2009-07-14 18:58 ` Andrew Lutomirski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb0375e10907141158l345742e3t1a252d1d1d0db526@mail.gmail.com \
--to=amluto@gmail.com \
--cc=davem@davemloft.net \
--cc=eeeesti@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).