* [PATCH] dlm: Make name input parameter of {,dlm_}new_lockspace() const
@ 2009-04-07 21:40 Geert Uytterhoeven
2009-04-08 14:05 ` David Teigland
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2009-04-07 21:40 UTC (permalink / raw)
To: David Teigland; +Cc: Linux Kernel Development
| fs/gfs2/lock_dlm.c:207: warning: passing argument 1 of 'dlm_new_lockspace' discards qualifiers from pointer target type
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
fs/dlm/lockspace.c | 4 ++--
include/linux/dlm.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
index cd8e2df..82528d9 100644
--- a/fs/dlm/lockspace.c
+++ b/fs/dlm/lockspace.c
@@ -384,7 +384,7 @@ static void threads_stop(void)
dlm_astd_stop();
}
-static int new_lockspace(char *name, int namelen, void **lockspace,
+static int new_lockspace(const char *name, int namelen, void **lockspace,
uint32_t flags, int lvblen)
{
struct dlm_ls *ls;
@@ -614,7 +614,7 @@ static int new_lockspace(char *name, int namelen, void **lockspace,
return error;
}
-int dlm_new_lockspace(char *name, int namelen, void **lockspace,
+int dlm_new_lockspace(const char *name, int namelen, void **lockspace,
uint32_t flags, int lvblen)
{
int error = 0;
diff --git a/include/linux/dlm.h b/include/linux/dlm.h
index b9cd386..0b3518c 100644
--- a/include/linux/dlm.h
+++ b/include/linux/dlm.h
@@ -81,8 +81,8 @@ struct dlm_lksb {
* the cluster, the calling node joins it.
*/
-int dlm_new_lockspace(char *name, int namelen, dlm_lockspace_t **lockspace,
- uint32_t flags, int lvblen);
+int dlm_new_lockspace(const char *name, int namelen,
+ dlm_lockspace_t **lockspace, uint32_t flags, int lvblen);
/*
* dlm_release_lockspace
--
1.6.2.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dlm: Make name input parameter of {,dlm_}new_lockspace() const
2009-04-07 21:40 [PATCH] dlm: Make name input parameter of {,dlm_}new_lockspace() const Geert Uytterhoeven
@ 2009-04-08 14:05 ` David Teigland
0 siblings, 0 replies; 2+ messages in thread
From: David Teigland @ 2009-04-08 14:05 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linux Kernel Development
On Tue, Apr 07, 2009 at 11:40:39PM +0200, Geert Uytterhoeven wrote:
> | fs/gfs2/lock_dlm.c:207: warning: passing argument 1 of 'dlm_new_lockspace' discards qualifiers from pointer target type
>
Thanks, added to dlm.git.
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-08 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-07 21:40 [PATCH] dlm: Make name input parameter of {,dlm_}new_lockspace() const Geert Uytterhoeven
2009-04-08 14:05 ` David Teigland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).