linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] reiserfs: fix printk format warning
@ 2009-04-03  1:34 Alexander Beregalov
  2009-04-09 20:58 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Beregalov @ 2009-04-03  1:34 UTC (permalink / raw)
  To: Jeff Mahoney, reiserfs-devel, linux-kernel

Fix following warning message
fs/reiserfs/procfs.c:393: warning: format '%u' expects type 'unsigned int', but argument 22 has type 'long unsigned int'
introduced in 600ed4167
(reiserfs: audit transaction ids to always be unsigned ints)

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---

 include/linux/reiserfs_fs_sb.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/reiserfs_fs_sb.h b/include/linux/reiserfs_fs_sb.h
index 5621d87..1d1594a 100644
--- a/include/linux/reiserfs_fs_sb.h
+++ b/include/linux/reiserfs_fs_sb.h
@@ -193,7 +193,7 @@ struct reiserfs_journal {
 	atomic_t j_wcount;	/* count of writers for current commit */
 	unsigned long j_bcount;	/* batch count. allows turning X transactions into 1 */
 	unsigned long j_first_unflushed_offset;	/* first unflushed transactions offset */
-	unsigned long j_last_flush_trans_id;	/* last fully flushed journal timestamp */
+	unsigned int j_last_flush_trans_id;	/* last fully flushed journal timestamp */
 	struct buffer_head *j_header_bh;
 
 	time_t j_trans_start_time;	/* time this transaction started */

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] reiserfs: fix printk format warning
  2009-04-03  1:34 [PATCH] reiserfs: fix printk format warning Alexander Beregalov
@ 2009-04-09 20:58 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2009-04-09 20:58 UTC (permalink / raw)
  To: Alexander Beregalov; +Cc: jeffm, reiserfs-devel, linux-kernel

On Fri, 3 Apr 2009 05:34:37 +0400
Alexander Beregalov <a.beregalov@gmail.com> wrote:

> Fix following warning message
> fs/reiserfs/procfs.c:393: warning: format '%u' expects type 'unsigned int', but argument 22 has type 'long unsigned int'
> introduced in 600ed4167
> (reiserfs: audit transaction ids to always be unsigned ints)
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
> ---
> 
>  include/linux/reiserfs_fs_sb.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/reiserfs_fs_sb.h b/include/linux/reiserfs_fs_sb.h
> index 5621d87..1d1594a 100644
> --- a/include/linux/reiserfs_fs_sb.h
> +++ b/include/linux/reiserfs_fs_sb.h
> @@ -193,7 +193,7 @@ struct reiserfs_journal {
>  	atomic_t j_wcount;	/* count of writers for current commit */
>  	unsigned long j_bcount;	/* batch count. allows turning X transactions into 1 */
>  	unsigned long j_first_unflushed_offset;	/* first unflushed transactions offset */
> -	unsigned long j_last_flush_trans_id;	/* last fully flushed journal timestamp */
> +	unsigned int j_last_flush_trans_id;	/* last fully flushed journal timestamp */
>  	struct buffer_head *j_header_bh;
>  
>  	time_t j_trans_start_time;	/* time this transaction started */

Yes, looking at the code I think it does want to be a u32.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-04-09 21:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-03  1:34 [PATCH] reiserfs: fix printk format warning Alexander Beregalov
2009-04-09 20:58 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).