From: Alexey Dobriyan <adobriyan@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: akpm@linux-foundation.org, containers@lists.linux-foundation.org,
xemul@parallels.com, serue@us.ibm.com, dave@linux.vnet.ibm.com,
mingo@elte.hu, orenl@cs.columbia.edu, hch@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style
Date: Mon, 13 Apr 2009 11:39:25 +0400 [thread overview]
Message-ID: <20090413073925.GB7085@x200.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.00.0904100758410.4583@localhost.localdomain>
On Fri, Apr 10, 2009 at 08:06:55AM -0700, Linus Torvalds wrote:
> On Fri, 10 Apr 2009, Alexey Dobriyan wrote:
> >
> > This is to show how we see C/R and to provoke discussion on number of
> > important issues (mounts, ...).
>
> My only initial reaction is that I absolutely hate the naming (not to say
> I love the code - just to say that I didn't even look at it, because I got
> hung up on the name).
>
> "cr"? It could be anything. I realize that to _you_ that is meaningful,
> but to somebody less specifically interested in checkpoint-restore 'cr'
> means 'carriage return' or just doesn't really say anything at all.
Well, in OpenVZ everything is in kernel/cpt/ and prefixed with "cpt_"
and "rst_". And I think "cr_" is super nice prefix: it's short, it's C-like,
it reminds about restart part. Eventually, C/R will become standard
in-kernel thing everyone should be at least aware of, so it's like
learning what "vma" means.
> That goes both for file naming (kernel/cr/xyzzy.c) and to a lesser degree
> for function naming too. I also don't think it makes sense to have
> something like kernel/cr/cr-x86_32.c or kernel/cr/cr-tty.c - maybe that is
> good right now, but I sure hope that the long-term goal is to have these
> things in the code that will need to change them when the code gets
> updated (ie arch/x86/kernel and drivers/char/)
In the long run, yes, C/R should be moved closer to core code it tries to
checkpoint. Right now, however, doing "make kernel/cr/" is much quicker
and C/R can not do much, so it's unclear how exactly splitting should be
done.
next prev parent reply other threads:[~2009-04-13 7:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 2:32 [PATCH 00/30] C/R OpenVZ/Virtuozzo style Alexey Dobriyan
2009-04-10 2:44 ` Alexey Dobriyan
2009-04-10 5:07 ` Dave Hansen
2009-04-13 9:14 ` Alexey Dobriyan
2009-04-13 11:16 ` Dave Hansen
2009-04-13 18:07 ` Dave Hansen
2009-04-14 4:26 ` Oren Laadan
2009-04-14 14:58 ` Alexey Dobriyan
2009-04-14 18:08 ` Oren Laadan
2009-04-14 18:34 ` Alexey Dobriyan
2009-04-14 19:31 ` Oren Laadan
2009-04-14 20:08 ` Alexey Dobriyan
2009-04-14 20:49 ` Alexey Dobriyan
2009-04-14 21:11 ` Dave Hansen
2009-04-14 21:39 ` Serge E. Hallyn
2009-04-15 19:21 ` CAP_SYS_ADMIN on restart(2) (was: Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style) Alexey Dobriyan
2009-04-15 20:22 ` Serge E. Hallyn
2009-04-15 20:23 ` Dave Hansen
2009-04-15 20:39 ` Serge E. Hallyn
2009-04-15 21:05 ` CAP_SYS_ADMIN on restart(2) Oren Laadan
2009-04-15 21:16 ` Serge E. Hallyn
2009-04-16 15:35 ` Alexey Dobriyan
2009-04-16 16:29 ` Serge E. Hallyn
2009-04-10 8:28 ` [PATCH 00/30] C/R OpenVZ/Virtuozzo style Ingo Molnar
2009-04-10 11:45 ` Alexey Dobriyan
2009-04-10 15:06 ` Linus Torvalds
2009-04-13 7:39 ` Alexey Dobriyan [this message]
2009-04-13 18:39 ` Linus Torvalds
2009-04-13 19:30 ` Ingo Molnar
2009-04-14 12:29 ` Alexey Dobriyan
2009-04-14 13:44 ` Ingo Molnar
2009-04-14 16:53 ` Alexey Dobriyan
2009-04-14 17:09 ` Linus Torvalds
2009-04-14 17:19 ` Randy Dunlap
2009-04-14 17:32 ` Linus Torvalds
2009-04-14 5:46 ` Oren Laadan
2009-04-14 15:19 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413073925.GB7085@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=orenl@cs.columbia.edu \
--cc=serue@us.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).