linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: rtc-linux@googlegroups.com
Cc: david-b@pacbell.net, Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	hcegtvedt@atmel.com, vapier@gentoo.org,
	rongkai.zhan@windriver.com, balajirrao@openmoko.org,
	broonie@opensource.wolfsonmicro.com
Subject: Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled
Date: Thu, 23 Apr 2009 20:27:49 +0200	[thread overview]
Message-ID: <20090423202749.767ab73b@i1501.lan.towertech.it> (raw)
In-Reply-To: <200904231115.57525.david-b@pacbell.net>

On Thu, 23 Apr 2009 11:15:56 -0700
David Brownell <david-b@pacbell.net> wrote:

> On Thursday 23 April 2009, Alessandro Zummo wrote:
> >  Is not an API change, we are gradually relaxing it if it
> >  proves workable :)
> 
> Erm, it *is* an API change at least to the extent that
> the last version of the patch made the interface spec
> become incorrect.

 I know, I was just playing it down :)
 
> Current interface spec *requires* that function to be
> called with IRQs disabled.
> 
> The downside of that spec is that there's no way to test
> it, since CONFIG_LOCKDEP doesn't understand that almost
> all IRQ handlers don't disable IRQs.  So there are some
> bugs in RTC drivers that can only be uncovered by code
> review.

 That's was what I was proposing. I'll give a code review
 but will not be able to test every driver so I'll need
 help from the authors. 

 But first I need someone to validate the theory that
 says that we don't really need the IRQs to be disabled,
 as I stated in the email to Andrew.

 do you agree? :)

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


  reply	other threads:[~2009-04-23 18:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 16:50 [PATCH] rtc: Make rtc_update_irq callable with irqs enabled Atsushi Nemoto
2009-04-09 22:39 ` Andrew Morton
2009-04-09 22:58   ` Alessandro Zummo
2009-04-23 14:51     ` Atsushi Nemoto
2009-04-23 15:02       ` Alessandro Zummo
2009-04-23 15:07         ` [rtc-linux] " Mike Frysinger
     [not found]           ` <200904091627.15776.david-b@pacbell.net>
2009-04-23 15:29             ` Atsushi Nemoto
2009-04-23 15:46               ` Alessandro Zummo
2009-04-23 18:15                 ` David Brownell
2009-04-23 18:27                   ` Alessandro Zummo [this message]
2009-04-23 19:02                     ` [rtc-linux] " David Brownell
2009-04-23 19:09                       ` Alessandro Zummo
2009-04-23 19:25                         ` David Brownell
2009-04-23 19:26                           ` Alessandro Zummo
2009-04-23 19:45                             ` David Brownell
2009-04-23 19:55                               ` Alessandro Zummo
2009-04-24  9:31                                 ` David Brownell
2009-04-24 10:01                                   ` Alessandro Zummo
2009-04-24 11:10                                     ` David Brownell
2009-04-24 11:13                                       ` Alessandro Zummo
2009-04-24 16:48                                         ` Atsushi Nemoto
2009-04-24 17:06                                           ` Atsushi Nemoto
2009-04-24 19:41                                             ` Alessandro Zummo
2009-04-25 12:40                                               ` Atsushi Nemoto
2009-04-28 13:13                                             ` Hans-Christian Egtvedt
2009-04-28 15:56                                               ` Atsushi Nemoto
2009-04-23 15:37           ` Alessandro Zummo
2009-04-23 16:30             ` Mike Frysinger
2009-04-23 16:40               ` Alessandro Zummo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090423202749.767ab73b@i1501.lan.towertech.it \
    --to=alessandro.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=balajirrao@openmoko.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=david-b@pacbell.net \
    --cc=hcegtvedt@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rongkai.zhan@windriver.com \
    --cc=rtc-linux@googlegroups.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).