From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: alessandro.zummo@towertech.it, rtc-linux@googlegroups.com,
david-b@pacbell.net, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, hcegtvedt@atmel.com,
vapier@gentoo.org, rongkai.zhan@windriver.com,
balajirrao@openmoko.org, broonie@opensource.wolfsonmicro.com
Subject: Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled
Date: Tue, 28 Apr 2009 15:13:53 +0200 [thread overview]
Message-ID: <20090428151353.0c15c5fc@hcegtvedt.norway.atmel.com> (raw)
In-Reply-To: <20090425.020612.92585418.anemo@mba.ocn.ne.jp>
On Sat, 25 Apr 2009 02:06:12 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Sat, 25 Apr 2009 01:48:50 +0900 (JST), Atsushi Nemoto
> <anemo@mba.ocn.ne.jp> wrote:
> > Here is a possible example:
> >
> > 1. RTC alarm interrupt handler takes rtc->irq_lock by spin_lock()
> > 2. A timer interrupt handler calls rtc_uie_timer() for UIE emulation
> > 3. rtc_uie_timer() waits on rtc->irq_lock .... deadlock!
>
> Oops, this is wrong. This deadlock cannot happen since
> rtc_uie_timer() will be called in bh (softirq) context, not interrupt
> context.
>
> Anyway, I just posted updated patch. Please take a look. Thanks.
>
AVR32 has interrupts disabled during the interrupt handler, so AFAICT
the rtc-at32ap700x.c should be fine.
--
Best regards,
Hans-Christian Egtvedt
next prev parent reply other threads:[~2009-04-28 13:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 16:50 [PATCH] rtc: Make rtc_update_irq callable with irqs enabled Atsushi Nemoto
2009-04-09 22:39 ` Andrew Morton
2009-04-09 22:58 ` Alessandro Zummo
2009-04-23 14:51 ` Atsushi Nemoto
2009-04-23 15:02 ` Alessandro Zummo
2009-04-23 15:07 ` [rtc-linux] " Mike Frysinger
[not found] ` <200904091627.15776.david-b@pacbell.net>
2009-04-23 15:29 ` Atsushi Nemoto
2009-04-23 15:46 ` Alessandro Zummo
2009-04-23 18:15 ` David Brownell
2009-04-23 18:27 ` [rtc-linux] " Alessandro Zummo
2009-04-23 19:02 ` David Brownell
2009-04-23 19:09 ` Alessandro Zummo
2009-04-23 19:25 ` David Brownell
2009-04-23 19:26 ` Alessandro Zummo
2009-04-23 19:45 ` David Brownell
2009-04-23 19:55 ` Alessandro Zummo
2009-04-24 9:31 ` David Brownell
2009-04-24 10:01 ` Alessandro Zummo
2009-04-24 11:10 ` David Brownell
2009-04-24 11:13 ` Alessandro Zummo
2009-04-24 16:48 ` Atsushi Nemoto
2009-04-24 17:06 ` Atsushi Nemoto
2009-04-24 19:41 ` Alessandro Zummo
2009-04-25 12:40 ` Atsushi Nemoto
2009-04-28 13:13 ` Hans-Christian Egtvedt [this message]
2009-04-28 15:56 ` Atsushi Nemoto
2009-04-23 15:37 ` Alessandro Zummo
2009-04-23 16:30 ` Mike Frysinger
2009-04-23 16:40 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090428151353.0c15c5fc@hcegtvedt.norway.atmel.com \
--to=hans-christian.egtvedt@atmel.com \
--cc=akpm@linux-foundation.org \
--cc=alessandro.zummo@towertech.it \
--cc=anemo@mba.ocn.ne.jp \
--cc=balajirrao@openmoko.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david-b@pacbell.net \
--cc=hcegtvedt@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rongkai.zhan@windriver.com \
--cc=rtc-linux@googlegroups.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).