* [PATCH] fs/super.c: fix sparse warning
@ 2009-04-30 0:14 H Hartley Sweeten
2009-04-30 0:42 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2009-04-30 0:14 UTC (permalink / raw)
To: linux-kernel
Sparse reports the following in fs/super.c:
warning: Using plain integer as NULL pointer
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Subrata Modak <subrata@linux.vnet.ibm.com>
---
diff --git a/fs/super.c b/fs/super.c
index 786fe7d..14e59bc 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -897,7 +897,7 @@ void kill_block_super(struct super_block *sb)
struct block_device *bdev = sb->s_bdev;
fmode_t mode = sb->s_mode;
- bdev->bd_super = 0;
+ bdev->bd_super = NULL;
generic_shutdown_super(sb);
sync_blockdev(bdev);
close_bdev_exclusive(bdev, mode);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/super.c: fix sparse warning
2009-04-30 0:14 [PATCH] fs/super.c: fix sparse warning H Hartley Sweeten
@ 2009-04-30 0:42 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2009-04-30 0:42 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: linux-kernel
On Wed, Apr 29, 2009 at 08:14:57PM -0400, H Hartley Sweeten wrote:
> Sparse reports the following in fs/super.c:
>
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Subrata Modak <subrata@linux.vnet.ibm.com>
Applied.
However, I would *really* ask you to avoid that kind of subjects in
the future. Proper subject for that one is "NULL noise in <file>" (or
<file>:<function>. Sparse doesn't even need to be mentioned.
sparse generates many kinds of warnings. And they are neither equal
nor equally interesting.
Kindly use subjects that would tell what's going on; "$TOOL gives
some warning in $FILE" is bloody useless.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-30 0:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-30 0:14 [PATCH] fs/super.c: fix sparse warning H Hartley Sweeten
2009-04-30 0:42 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).