linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] of_serial: remove driver_data direct access of struct device
@ 2009-05-04 20:13 Greg Kroah-Hartman
  2009-05-04 23:53 ` Stephen Rothwell
  2009-05-05 11:00 ` Arnd Bergmann
  0 siblings, 2 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2009-05-04 20:13 UTC (permalink / raw)
  To: Benjamin Herrenschmidt, Arnd Bergmann, Stephen Rothwell,
	Paul Mackerras, Matthias Fuchs
  Cc: Greg KH, linux-kernel

From: Greg Kroah-Hartman <gregkh@suse.de>

In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device.  Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used.  These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Matthias Fuchs <mfuchs@ma-fu.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/serial/of_serial.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/serial/of_serial.c
+++ b/drivers/serial/of_serial.c
@@ -122,7 +122,7 @@ static int __devinit of_platform_serial_
 
 	info->type = port_type;
 	info->line = ret;
-	ofdev->dev.driver_data = info;
+	dev_set_drvdata(&ofdev->dev, info);
 	return 0;
 out:
 	kfree(info);
@@ -135,7 +135,7 @@ out:
  */
 static int of_platform_serial_remove(struct of_device *ofdev)
 {
-	struct of_serial_info *info = ofdev->dev.driver_data;
+	struct of_serial_info *info = dev_get_drvdata(&ofdev->dev);
 	switch (info->type) {
 #ifdef CONFIG_SERIAL_8250
 	case PORT_8250 ... PORT_MAX_8250:

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-05-11 21:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-04 20:13 [PATCH] of_serial: remove driver_data direct access of struct device Greg Kroah-Hartman
2009-05-04 23:53 ` Stephen Rothwell
2009-05-11 21:05   ` Greg KH
2009-05-05 11:00 ` Arnd Bergmann
2009-05-11 21:05   ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).