Gerrit (was Re: HTC Dream aka. t-mobile g1 support)

Gerrit (was Re: HTC Dream aka. t-mobile g1 support)

[Brian Swetland]

On Fri, Jun 12, 2009 at 10:35 AM, Stefan
Schmidt<stefan@datenfreihafen.org> wrote:
>> I think the intent is to have a
>> Gerrit instance to accept contributions.  I'll have to look into
>> whether this can be done without signing the agreement.  Right
>> now, I can't even contribute anything, so there are a lot of
>> issues to work out.
>
> Gerrit is the Android review system? I'm only interested into the kernel and
> especially running a mainline kernel on different devices. Anyway, a public
> review process and some more informations on what you are working and how you
> would like to bring it mainline would help here.

Gerrit is a git patch review system that we (Google/Android) use for
android development (kernel and otherwise).  Some other folks like
Qualcomm, and TI (see http://review.omapzoom.org/) have adopted it as
well.  We're still happy to accept patches via email and
review/discuss them on the usual mailing lists as well.  It'd be cool
to get an automated process set up to slurp submitted patches into
Gerrit at some point, and further unify the two different workflows.

Gerrit's very actively maintained by Shawn O. Pearce:
http://code.google.com/p/gerrit/

Here's an example of a patch in Gerrit (though a dull one -- when
logged in you can basically annotate the diff with line by line
comments, etc, which is pretty slick if you like that sort of thing):
https://review.source.android.com/10348

Brian

Re: Gerrit (was Re: HTC Dream aka. t-mobile g1 support)

[Pavel Machek]

On Fri 2009-06-12 14:50:21, Brian Swetland wrote:
> On Fri, Jun 12, 2009 at 10:35 AM, Stefan
> Schmidt<stefan@datenfreihafen.org> wrote:
> >> I think the intent is to have a
> >> Gerrit instance to accept contributions.  I'll have to look into
> >> whether this can be done without signing the agreement.  Right
> >> now, I can't even contribute anything, so there are a lot of
> >> issues to work out.
> >
> > Gerrit is the Android review system? I'm only interested into the kernel and
> > especially running a mainline kernel on different devices. Anyway, a public
> > review process and some more informations on what you are working and how you
> > would like to bring it mainline would help here.
> 
> Gerrit is a git patch review system that we (Google/Android) use for
> android development (kernel and otherwise).  Some other folks like
> Qualcomm, and TI (see http://review.omapzoom.org/) have adopted it

Unfortunately, it seems quite unsuitable for kernel.

Do I understand it right that to submit kernel patches I'd have to
agree to "contributors agreement", and give up my copyright? No,
sorry, I don't think I want to do that.

	(I may be willing to do that for Android proper -- after
	studying the agreement carefully, but not for GPLed kernel
	code).
	
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: Gerrit (was Re: HTC Dream aka. t-mobile g1 support)

[Brian Swetland]

On Fri, Jun 12, 2009 at 3:38 PM, Shawn Pearce<sop@google.com> wrote:
> On Fri, Jun 12, 2009 at 15:22, Pavel Machek <pavel@ucw.cz> wrote:
>> On Fri 2009-06-12 14:50:21, Brian Swetland wrote:
>> > Gerrit is a git patch review system that we (Google/Android) use for
>>
>> Unfortunately, it seems quite unsuitable for kernel.
>>
>> Do I understand it right that to submit kernel patches I'd have to
>> agree to "contributors agreement", and give up my copyright? No,
>> sorry, I don't think I want to do that.
>
> No.  The contributor agreement used by review.source.android.com is a stronger version of the Developers Certificate of Origin normally used by kernel
> contributors.
> For the actual agreement text see[1], but the basic principle is the same.
>  No assignment of copyright, only assignment of license for redistribution,
> which is what the GPL asks anyway.  It also contains a patent provision,
> similar to what the Apache License contains, to protect the project leads
> from submarine patent infringement by code contributed by a patent holder.
> [1] https://review.source.android.com/static/cla_individual.html

When we first discussed the CLA, I raised this concern (that the
mainline kernel folks would not be thrilled by another system in
addition to Signed-off-by), and was informed that we should not have
to require CLA acceptance for contributions to the kernel/... trees.
I'm not sure if Gerrit is setup to handle this yet.

We will always happily accept kernel patches via email/mailinglist,
per the standard linux kernel development model.

Brian

Re: Gerrit (was Re: HTC Dream aka. t-mobile g1 support)

[Shawn Pearce]

On Fri, Jun 12, 2009 at 15:42, Brian Swetland <swetland@google.com> wrote:
> When we first discussed the CLA, I raised this concern (that the
> mainline kernel folks would not be thrilled by another system in
> addition to Signed-off-by), and was informed that we should not have
> to require CLA acceptance for contributions to the kernel/... trees.
> I'm not sure if Gerrit is setup to handle this yet.

It is, but we haven't flipped the bit on the kernel projects that says
"no CLA".  I can do that if you want me to.

Re: Gerrit (was Re: HTC Dream aka. t-mobile g1 support)

[Brian Swetland]

On Fri, Jun 12, 2009 at 3:43 PM, Shawn Pearce<sop@google.com> wrote:
> On Fri, Jun 12, 2009 at 15:42, Brian Swetland <swetland@google.com> wrote:
>> When we first discussed the CLA, I raised this concern (that the
>> mainline kernel folks would not be thrilled by another system in
>> addition to Signed-off-by), and was informed that we should not have
>> to require CLA acceptance for contributions to the kernel/... trees.
>> I'm not sure if Gerrit is setup to handle this yet.
>
> It is, but we haven't flipped the bit on the kernel projects that says
> "no CLA".  I can do that if you want me to.

Please do.  Thanks!

Brian

Re: Gerrit (was Re: HTC Dream aka. t-mobile g1 support)

[Pavel Machek]

Hi!

>    On Fri 2009-06-12 14:50:21, Brian Swetland wrote:
>    > Gerrit is a git patch review system that we (Google/Android) use for
>    > android development (kernel and otherwise).  Some other folks like
>    > Qualcomm, and TI (see [2]http://review.omapzoom.org/) have adopted it
> 
>      Unfortunately, it seems quite unsuitable for kernel.
>      Do I understand it right that to submit kernel patches I'd have to
>      agree to "contributors agreement", and give up my copyright? No,
>      sorry, I don't think I want to do that.
> 
>    No.  The contributor agreement used by [3]review.source.android.com is
>    a stronger version of the Developers Certificate of Origin normally use
>    d by kernel contributors.

So, agreeing to that is neccessary for using Gerrit? Too bad. As I
said, it is unsuitable for kernel patches.

>    For the actual agreement text see[1], but the basic principle is the
>    same.  No assignment of copyright, only assignment of license for
>    redistribution, which is what the GPL asks anyway.  It also

As I read it, it is very different from GPL.

It grants google license to do anything with that code, such as
packaging it into closed source product.

# 2. Grant of Copyright License. Subject to the terms and conditions of
# this Grant, You hereby grant to the Project Leads and to recipients of
# software distributed by the Project Leads a perpetual, worldwide,
# non-exclusive, no-charge, royalty-free, irrevocable copyright license
# to reproduce, prepare derivative works of, publicly display, publicly
# perform, sublicense, and distribute Your Contributions and such
# derivative works.

Kernel already has GPL license and Developers Certificate of Origin,
so please just use that for the kernel. (Kernel also has perfectly
working patch review system called mailing lists and git trees; please
use that, too).

>    patent provision, similar to what the Apache License contains, to
>    protect the project leads from submarine patent infringement by code
>    contributed by a patent holder.
>    [1] [4]https://review.source.android.com/static/cla_individual.html

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: Gerrit (was Re: HTC Dream aka. t-mobile g1 support)

[Pavel Machek]

> We will always happily accept kernel patches via email/mailinglist,
> per the standard linux kernel development model.

Thanks!
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html