LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Ondrej Zary <linux@rainbow-software.org>
To: gregkh@suse.de
Cc: linux-usb@vger.kernel.org, "linux-kernel" <linux-kernel@vger.kernel.org>
Subject: [PATCH] [RFC] ark3116: add IrDA support (for Gembird UIR-22)
Date: Sun, 26 Jul 2009 14:19:47 +0200
Message-ID: <200907261419.50702.linux@rainbow-software.org> (raw)

Hello,
I got a Gembird UIR-22 USB to IrDA adapter (vendor ID 0x18ec, device ID 0x3118)
that did not work in Linux at all. So I opened it and found ARK3116T chip and
IrDA transceiver inside. Adding the IDs to ark3116 driver was not enough -
irdadump did not show any received data.

The next step was usbsnoop to find what windows driver does with the device.
The result is the patch below. Now the device works after plugging and running
"irattach /dev/ttyUSB0 -s".

But how to make it appear as a real IrDA device by itself? Another problem is
mixing IrDA with USB serial driver. Is a separate driver (something like
ark3116-irda) needed?


Signed-off-by: Ondrej Zary <linux@rainbow-software.org>

--- linux-2.6.30-orig/drivers/usb/serial/ark3116.c	2009-07-19 19:21:54.000000000 +0200
+++ linux/drivers/usb/serial/ark3116.c	2009-07-26 13:58:04.000000000 +0200
@@ -31,6 +31,7 @@
 
 static struct usb_device_id id_table [] = {
 	{ USB_DEVICE(0x6547, 0x0232) },
+	{ USB_DEVICE(0x18ec, 0x3118) },		/* USB to IrDA adapter */
 	{ },
 };
 MODULE_DEVICE_TABLE(usb, id_table);
@@ -83,7 +84,7 @@
 {
 	char *buf;
 	struct ark3116_private *priv;
-	int i;
+	int i, irda;
 
 	for (i = 0; i < serial->num_ports; ++i) {
 		priv = kzalloc(sizeof(struct ark3116_private), GFP_KERNEL);
@@ -100,11 +101,21 @@
 		goto cleanup;
 	}
 
+	irda = le16_to_cpu(serial->dev->descriptor.idProduct) == 0x3118;
+	if (irda)
+		dbg("IrDA mode");
+
 	/* 3 */
 	ARK3116_SND(serial, 3, 0xFE, 0x40, 0x0008, 0x0002);
 	ARK3116_SND(serial, 4, 0xFE, 0x40, 0x0008, 0x0001);
 	ARK3116_SND(serial, 5, 0xFE, 0x40, 0x0000, 0x0008);
-	ARK3116_SND(serial, 6, 0xFE, 0x40, 0x0000, 0x000B);
+	ARK3116_SND(serial, 6, 0xFE, 0x40, irda ? 0x0001 : 0x0000, 0x000B);
+
+	if (irda) {
+		ARK3116_SND(serial, 1001, 0xFE, 0x40, 0x0000, 0x000C);
+		ARK3116_SND(serial, 1002, 0xFE, 0x40, 0x0041, 0x000D);
+		ARK3116_SND(serial, 1003, 0xFE, 0x40, 0x0001, 0x000A);
+	}
 
 	/* <-- seq7 */
 	ARK3116_RCV(serial,  7, 0xFE, 0xC0, 0x0000, 0x0003, 0x00, buf);
@@ -141,6 +152,8 @@
 	ARK3116_SND(serial, 147, 0xFE, 0x40, 0x0083, 0x0003);
 	ARK3116_SND(serial, 148, 0xFE, 0x40, 0x0038, 0x0000);
 	ARK3116_SND(serial, 149, 0xFE, 0x40, 0x0001, 0x0001);
+	if (irda)
+		ARK3116_SND(serial, 1004, 0xFE, 0x40, 0x0000, 0x0009);
 	ARK3116_SND(serial, 150, 0xFE, 0x40, 0x0003, 0x0003);
 	ARK3116_RCV(serial, 151, 0xFE, 0xC0, 0x0000, 0x0004, 0x03, buf);
 	ARK3116_SND(serial, 152, 0xFE, 0x40, 0x0000, 0x0003);

-- 
Ondrej Zary

             reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-26 12:19 Ondrej Zary [this message]
2009-07-27 10:15 ` Alan Cox
2009-08-01 20:36   ` Ondrej Zary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907261419.50702.linux@rainbow-software.org \
    --to=linux@rainbow-software.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git