From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: gregkh@suse.de, linux-usb@vger.kernel.org,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [RFC] ark3116: add IrDA support (for Gembird UIR-22)
Date: Mon, 27 Jul 2009 11:15:15 +0100 [thread overview]
Message-ID: <20090727111515.7d5f359f@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200907261419.50702.linux@rainbow-software.org>
> The next step was usbsnoop to find what windows driver does with the device.
> The result is the patch below. Now the device works after plugging and running
> "irattach /dev/ttyUSB0 -s".
>
> But how to make it appear as a real IrDA device by itself? Another problem is
> mixing IrDA with USB serial driver. Is a separate driver (something like
> ark3116-irda) needed?
For standard devices using serial/tty then irattach is the right way to
do it. Nothing else should be needed.
> + irda = le16_to_cpu(serial->dev->descriptor.idProduct) == 0x3118;
> + if (irda)
> + dbg("IrDA mode");
> +
I would split this out into
static int is_irda(serial) { }
just so that anyone who needs to add more irda adapters can find it
easily and do so neatly.
Alan
next prev parent reply other threads:[~2009-07-27 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-26 12:19 [PATCH] [RFC] ark3116: add IrDA support (for Gembird UIR-22) Ondrej Zary
2009-07-27 10:15 ` Alan Cox [this message]
2009-08-01 20:36 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090727111515.7d5f359f@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).