Re: [Bug #14057] Strange network timeouts w/ e100

Re: [Bug #14057] Strange network timeouts w/ e100

[Walt Holman]

----- "Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> This message has been generated automatically as a part of a report
> of recent regressions.
> 
> The following bug entry is on the current list of known regressions
> from 2.6.30.  Please verify if it still should be listed and let me
> know
> (either way).
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=14057
> Subject		: Strange network timeouts w/ e100
> Submitter	: Walt Holman <walt@holmansrus.com>
> Date		: 2009-08-20 0:21 (6 days old)
> References	: http://marc.info/?l=linux-kernel&m=125072831831443&w=4
> Handled-By	: Krzysztof Halasa <khc@pm.waw.pl>

Hi Rafael,

Krzysztof has a patch which has corrected this issue for me.  Thanks,

-Walt

Re: [Bug #14057] Strange network timeouts w/ e100

[Rafael J. Wysocki]

On Wednesday 26 August 2009, Walt Holman wrote:
> 
> ----- "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> > 
> > The following bug entry is on the current list of known regressions
> > from 2.6.30.  Please verify if it still should be listed and let me
> > know
> > (either way).
> > 
> > 
> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=14057
> > Subject		: Strange network timeouts w/ e100
> > Submitter	: Walt Holman <walt@holmansrus.com>
> > Date		: 2009-08-20 0:21 (6 days old)
> > References	: http://marc.info/?l=linux-kernel&m=125072831831443&w=4
> > Handled-By	: Krzysztof Halasa <khc@pm.waw.pl>
> 
> Hi Rafael,

Hi,

> Krzysztof has a patch which has corrected this issue for me.  Thanks,

Thanks for the update.

Do you have a pointer to the patch, please?

Rafael

Re: [Bug #14057] Strange network timeouts w/ e100

[Walt Holman]

----- "Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Wednesday 26 August 2009, Walt Holman wrote:
> > 
> > ----- "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> > 
> > > This message has been generated automatically as a part of a
> report
> > > of recent regressions.
> > > 
> > > The following bug entry is on the current list of known
> regressions
> > > from 2.6.30.  Please verify if it still should be listed and let
> me
> > > know
> > > (either way).
> > > 
> > > 
> > > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=14057
> > > Subject		: Strange network timeouts w/ e100
> > > Submitter	: Walt Holman <walt@holmansrus.com>
> > > Date		: 2009-08-20 0:21 (6 days old)
> > > References	:
> http://marc.info/?l=linux-kernel&m=125072831831443&w=4
> > > Handled-By	: Krzysztof Halasa <khc@pm.waw.pl>
> > 
> > Hi Rafael,
> 
> Hi,
> 
> > Krzysztof has a patch which has corrected this issue for me. 
> Thanks,
> 
> Thanks for the update.
> 
> Do you have a pointer to the patch, please?
> 
> Rafael

Yes, it's referenced in:

http://marc.info/?l=linux-netdev&m=125104144706982&w=2

Which was for 2.6.30.5  The same patch still applies on 2.6.31-rc7 with offset and that's actually where I tested it.  That resolved the timeouts for me.  I believe Krzysztof was going to get a patch in to -stable as well as for .31-rc before final.

-Walt

Re: [Bug #14057] Strange network timeouts w/ e100

[David Miller]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=utf-8, Size: 2033 bytes --]

From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Wed, 26 Aug 2009 23:12:03 +0200

>> Krzysztof has a patch which has corrected this issue for me.  Thanks,
> 
> Thanks for the update.
> 
> Do you have a pointer to the patch, please?

commit 6ff9c2e7fa8ca63a575792534b63c5092099c286
Author: Krzysztof Hałasa <khc@pm.waw.pl>
Date:   Sun Aug 23 19:02:13 2009 -0700

    E100: fix interaction with swiotlb on X86.
    
    E100 places it's RX packet descriptors inside skb->data and uses them
    with bidirectional streaming DMA mapping. Data in descriptors is
    accessed simultaneously by the chip (writing status and size when
    a packet is received) and CPU (reading to check if the packet was
    received). This isn't a valid usage of PCI DMA API, which requires use
    of the coherent (consistent) memory for such purpose. Unfortunately e100
    chips working in "simplified" RX mode have to store received data
    directly after the descriptor. Fixing the driver to conform to the API
    would require using unsupported "flexible" RX mode or receiving data
    into a coherent memory and using CPU to copy it to network buffers.
    
    This patch, while not yet making the driver conform to the PCI DMA API,
    allows it to work correctly on X86 with swiotlb (while not breaking
    other architectures).
    
    Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 41b648a..3a6735d 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -1899,7 +1899,7 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
 				nic->ru_running = RU_SUSPENDED;
 		pci_dma_sync_single_for_device(nic->pdev, rx->dma_addr,
 					       sizeof(struct rfd),
-					       PCI_DMA_BIDIRECTIONAL);
+					       PCI_DMA_FROMDEVICE);
 		return -ENODATA;
 	}
 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [Bug #14057] Strange network timeouts w/ e100

[Rafael J. Wysocki]

On Thursday 27 August 2009, David Miller wrote:
> From: "Rafael J. Wysocki" <rjw@sisk.pl>
> Date: Wed, 26 Aug 2009 23:12:03 +0200
> 
> >> Krzysztof has a patch which has corrected this issue for me.  Thanks,
> > 
> > Thanks for the update.
> > 
> > Do you have a pointer to the patch, please?
> 
> commit 6ff9c2e7fa8ca63a575792534b63c5092099c286
> Author: Krzysztof Hałasa <khc@pm.waw.pl>
> Date:   Sun Aug 23 19:02:13 2009 -0700
> 
>     E100: fix interaction with swiotlb on X86.
>     
>     E100 places it's RX packet descriptors inside skb->data and uses them
>     with bidirectional streaming DMA mapping. Data in descriptors is
>     accessed simultaneously by the chip (writing status and size when
>     a packet is received) and CPU (reading to check if the packet was
>     received). This isn't a valid usage of PCI DMA API, which requires use
>     of the coherent (consistent) memory for such purpose. Unfortunately e100
>     chips working in "simplified" RX mode have to store received data
>     directly after the descriptor. Fixing the driver to conform to the API
>     would require using unsupported "flexible" RX mode or receiving data
>     into a coherent memory and using CPU to copy it to network buffers.
>     
>     This patch, while not yet making the driver conform to the PCI DMA API,
>     allows it to work correctly on X86 with swiotlb (while not breaking
>     other architectures).
>     
>     Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> diff --git a/drivers/net/e100.c b/drivers/net/e100.c
> index 41b648a..3a6735d 100644
> --- a/drivers/net/e100.c
> +++ b/drivers/net/e100.c
> @@ -1899,7 +1899,7 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
>  				nic->ru_running = RU_SUSPENDED;
>  		pci_dma_sync_single_for_device(nic->pdev, rx->dma_addr,
>  					       sizeof(struct rfd),
> -					       PCI_DMA_BIDIRECTIONAL);
> +					       PCI_DMA_FROMDEVICE);
>  		return -ENODATA;
>  	}

Thanks a lot, bug closed.

Rafael

Re: [Bug #14057] Strange network timeouts w/ e100

[Ian Campbell]

[-- Attachment #1: Type: text/plain, Size: 2488 bytes --]

On Wed, 2009-08-26 at 15:11 -0700, David Miller wrote: 
> From: "Rafael J. Wysocki" <rjw@sisk.pl>
> Date: Wed, 26 Aug 2009 23:12:03 +0200
> 
> >> Krzysztof has a patch which has corrected this issue for me.  Thanks,
> > 
> > Thanks for the update.
> > 
> > Do you have a pointer to the patch, please?
> 
> commit 6ff9c2e7fa8ca63a575792534b63c5092099c286
> Author: Krzysztof Hałasa <khc@pm.waw.pl>
> Date:   Sun Aug 23 19:02:13 2009 -0700
> 
>     E100: fix interaction with swiotlb on X86.

This fixes 303d67c2 which has been included in at least the 2.6.27.29
and 2.6.30.5 stable releases so I think this should be a candidate for
those stable branches too.

Ian.

> 
>     E100 places it's RX packet descriptors inside skb->data and uses them
>     with bidirectional streaming DMA mapping. Data in descriptors is
>     accessed simultaneously by the chip (writing status and size when
>     a packet is received) and CPU (reading to check if the packet was
>     received). This isn't a valid usage of PCI DMA API, which requires use
>     of the coherent (consistent) memory for such purpose. Unfortunately e100
>     chips working in "simplified" RX mode have to store received data
>     directly after the descriptor. Fixing the driver to conform to the API
>     would require using unsupported "flexible" RX mode or receiving data
>     into a coherent memory and using CPU to copy it to network buffers.
>     
>     This patch, while not yet making the driver conform to the PCI DMA API,
>     allows it to work correctly on X86 with swiotlb (while not breaking
>     other architectures).
>     
>     Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> diff --git a/drivers/net/e100.c b/drivers/net/e100.c
> index 41b648a..3a6735d 100644
> --- a/drivers/net/e100.c
> +++ b/drivers/net/e100.c
> @@ -1899,7 +1899,7 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
>  				nic->ru_running = RU_SUSPENDED;
>  		pci_dma_sync_single_for_device(nic->pdev, rx->dma_addr,
>  					       sizeof(struct rfd),
> -					       PCI_DMA_BIDIRECTIONAL);
> +					       PCI_DMA_FROMDEVICE);
>  		return -ENODATA;
>  	}
>  
> NrybXǧv^)޺{.n+{zXܨ}Ơz&j:+vzZ++zfh~izw?&)ߢf^jǫym@Aa\x7f0hi\x7f
-- 
Ian Campbell

Q:	Why did the chicken cross the road?
A:	To see his friend Gregory peck.

Q:	Why did the chicken cross the playground?
A:	To get to the other slide.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [Bug #14057] Strange network timeouts w/ e100

[David Miller]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=utf-8, Size: 961 bytes --]

From: Ian Campbell <ijc@hellion.org.uk>
Date: Sun, 06 Sep 2009 12:22:58 +0100

> On Wed, 2009-08-26 at 15:11 -0700, David Miller wrote: 
>> From: "Rafael J. Wysocki" <rjw@sisk.pl>
>> Date: Wed, 26 Aug 2009 23:12:03 +0200
>> 
>> >> Krzysztof has a patch which has corrected this issue for me.  Thanks,
>> > 
>> > Thanks for the update.
>> > 
>> > Do you have a pointer to the patch, please?
>> 
>> commit 6ff9c2e7fa8ca63a575792534b63c5092099c286
>> Author: Krzysztof Hałasa <khc@pm.waw.pl>
>> Date:   Sun Aug 23 19:02:13 2009 -0700
>> 
>>     E100: fix interaction with swiotlb on X86.
> 
> This fixes 303d67c2 which has been included in at least the 2.6.27.29
> and 2.6.30.5 stable releases so I think this should be a candidate for
> those stable branches too.

Absolutely, I'll take care of this.

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

[Bug #14057] Strange network timeouts w/ e100

[Rafael J. Wysocki]

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.30.  Please verify if it still should be listed and let me know
(either way).


Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=14057
Subject		: Strange network timeouts w/ e100
Submitter	: Walt Holman <walt@holmansrus.com>
Date		: 2009-08-20 0:21 (6 days old)
References	: http://marc.info/?l=linux-kernel&m=125072831831443&w=4
Handled-By	: Krzysztof Halasa <khc@pm.waw.pl>