* [PATCH] drivers/net/atl1c/atl1c_main.c: use %pM to show MAC address
@ 2010-01-05 16:54 H Hartley Sweeten
2010-01-07 9:18 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: H Hartley Sweeten @ 2010-01-05 16:54 UTC (permalink / raw)
To: Linux Kernel; +Cc: netdev, davem
Use the %pM kernel extension to display the MAC address.
The only difference in the output is that the MAC address is
shown in the usual colon-separated hex notation.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: David S. Miller <davem@davemloft.net>
---
Repost due to merge issues.
diff --git a/drivers/net/atl1c/atl1c_main.c b/drivers/net/atl1c/atl1c_main.c
index 2f4be59..77cde85 100644
--- a/drivers/net/atl1c/atl1c_main.c
+++ b/drivers/net/atl1c/atl1c_main.c
@@ -2596,11 +2596,8 @@ static int __devinit atl1c_probe(struct pci_dev *pdev,
memcpy(netdev->dev_addr, adapter->hw.mac_addr, netdev->addr_len);
memcpy(netdev->perm_addr, adapter->hw.mac_addr, netdev->addr_len);
if (netif_msg_probe(adapter))
- dev_dbg(&pdev->dev,
- "mac address : %02x-%02x-%02x-%02x-%02x-%02x\n",
- adapter->hw.mac_addr[0], adapter->hw.mac_addr[1],
- adapter->hw.mac_addr[2], adapter->hw.mac_addr[3],
- adapter->hw.mac_addr[4], adapter->hw.mac_addr[5]);
+ dev_dbg(&pdev->dev, "mac address : %pM\n",
+ adapter->hw.mac_addr);
atl1c_hw_set_mac_addr(&adapter->hw);
INIT_WORK(&adapter->common_task, atl1c_common_task);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/atl1c/atl1c_main.c: use %pM to show MAC address
2010-01-05 16:54 [PATCH] drivers/net/atl1c/atl1c_main.c: use %pM to show MAC address H Hartley Sweeten
@ 2010-01-07 9:18 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-01-07 9:18 UTC (permalink / raw)
To: hartleys; +Cc: linux-kernel, netdev
From: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Tue, 5 Jan 2010 09:54:01 -0700
> Use the %pM kernel extension to display the MAC address.
>
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] drivers/net/atl1c/atl1c_main.c: use %pM to show MAC address
@ 2009-12-30 20:06 H Hartley Sweeten
0 siblings, 0 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2009-12-30 20:06 UTC (permalink / raw)
To: linux-kernel, netdev; +Cc: David Miller
Use the %pM kernel extension to display the MAC address.
The only difference in the output is that the MAC address is
shown in the usual colon-separated hex notation.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: David S. Miller <davem@davemloft.net>
---
diff --git a/drivers/net/atl1c/atl1c_main.c b/drivers/net/atl1c/atl1c_main.c
index 2f4be59..77cde85 100644
--- a/drivers/net/atl1c/atl1c_main.c
+++ b/drivers/net/atl1c/atl1c_main.c
@@ -2596,11 +2596,8 @@ static int __devinit atl1c_probe(struct pci_dev *pdev,
memcpy(netdev->dev_addr, adapter->hw.mac_addr, netdev->addr_len);
memcpy(netdev->perm_addr, adapter->hw.mac_addr, netdev->addr_len);
if (netif_msg_probe(adapter))
- dev_dbg(&pdev->dev,
- "mac address : %02x-%02x-%02x-%02x-%02x-%02x\n",
- adapter->hw.mac_addr[0], adapter->hw.mac_addr[1],
- adapter->hw.mac_addr[2], adapter->hw.mac_addr[3],
- adapter->hw.mac_addr[4], adapter->hw.mac_addr[5]);
+ dev_dbg(&pdev->dev, "mac address : %pM\n",
+ adapter->hw.mac_addr);
atl1c_hw_set_mac_addr(&adapter->hw);
INIT_WORK(&adapter->common_task, atl1c_common_task);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-07 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-05 16:54 [PATCH] drivers/net/atl1c/atl1c_main.c: use %pM to show MAC address H Hartley Sweeten
2010-01-07 9:18 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-12-30 20:06 H Hartley Sweeten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).