[PATCH] obsolete config in kernel source (FB_SOFT_CURSOR)

[PATCH] obsolete config in kernel source (FB_SOFT_CURSOR)

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi all!

	As part of the VAMOS[0] research project at the University of
Erlangen we're checking referential integrity between kernel KConfig
options and in-code Conditional blocks.

	While probably not strictly a integrity violation (as
FB_SOFT_CURSOR can still be set as it is once mentioned in a KConfig
select statement this looks like a left-over of
c465e05a03209651078b95686158648fd7ed84c5

	Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.

Regards

	Christoph Egger

[0] http://vamos1.informatik.uni-erlangen.de/

[-- Attachment #2: 0001-Clean-missed-bit-of-FB_SOFT_CURSOR.patch --]
[-- Type: text/x-diff, Size: 1570 bytes --]

>From 5461c8d1ebc54e9f5c86233aa831cefc7c06a140 Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
Date: Fri, 15 Jan 2010 11:03:50 +0100
Subject: [PATCH 1/4] Clean missed bit of FB_SOFT_CURSOR

While the config Option FB_SOFT_BUFFER was removed in
c465e05a03209651078b95686158648fd7ed84c5 while moving to fbcon this
single driver has it left as a select in KConfig / #ifdef in
source. This last occurence is removed here so the option is really
gone

Signed-off-by: Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>
---
 drivers/video/Kconfig        |    1 -
 drivers/video/sis/sis_main.c |    3 ---
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 5a5c303..7fe1839 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -1494,7 +1494,6 @@ config FB_VIA
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
-       select FB_SOFT_CURSOR
        select I2C_ALGOBIT
        select I2C
        help
diff --git a/drivers/video/sis/sis_main.c b/drivers/video/sis/sis_main.c
index 9d2b6bc..a531a0f 100644
--- a/drivers/video/sis/sis_main.c
+++ b/drivers/video/sis/sis_main.c
@@ -1891,9 +1891,6 @@ static struct fb_ops sisfb_ops = {
 	.fb_fillrect	= fbcon_sis_fillrect,
 	.fb_copyarea	= fbcon_sis_copyarea,
 	.fb_imageblit	= cfb_imageblit,
-#ifdef CONFIG_FB_SOFT_CURSOR
-	.fb_cursor	= soft_cursor,
-#endif
 	.fb_sync	= fbcon_sis_sync,
 #ifdef SIS_NEW_CONFIG_COMPAT
 	.fb_compat_ioctl= sisfb_ioctl,
-- 
1.6.3.3

Re: [PATCH] obsolete config in kernel source (FB_SOFT_CURSOR)

[Randy Dunlap]

On Fri, 15 Jan 2010 13:27:56 +0100 Christoph Egger wrote:

> Hi all!
> 
> 	As part of the VAMOS[0] research project at the University of
> Erlangen we're checking referential integrity between kernel KConfig
> options and in-code Conditional blocks.
> 
> 	While probably not strictly a integrity violation (as
> FB_SOFT_CURSOR can still be set as it is once mentioned in a KConfig
> select statement this looks like a left-over of
> c465e05a03209651078b95686158648fd7ed84c5
> 
> 	Please keep me informed of this patch getting confirmed /
> merged so we can keep track of it.
> 
> Regards
> 
> 	Christoph Egger
> 
> [0] http://vamos1.informatik.uni-erlangen.de/

Hi,

This one should have gone to the linux-fbdev@vger.kernel.org mailing list
instead of linux-media.

http://vger.kernel.org/vger-lists.html#linux-fbdev

---
~Randy