flash_platform_data namespace collision

flash_platform_data namespace collision

[Matt Mackall]

I've got a board here with SPI, NOR, and NAND flash devices and I've
just run into a namespace collision on flash_platform_data from

 include/spi/flash.h

and

 arch/arm/include/asm/mach/flash.h

And each appears to have a bunch of users.

-- 
http://selenic.com : development and support for Mercurial and Linux

Re: flash_platform_data namespace collision

[David Brownell]

On Friday 15 January 2010, Matt Mackall wrote:
> I've got a board here with SPI, NOR, and NAND flash devices and I've
> just run into a namespace collision on flash_platform_data from
> 
>  include/spi/flash.h
> 
> and
> 
>  arch/arm/include/asm/mach/flash.h
> 
> And each appears to have a bunch of users.

ISTR someone noting that before but omitting a patch.

You can do that one better.  :)

I think changing the SPI flash name will affect fewer platforms.

- Dave

Re: flash_platform_data namespace collision

[Russell King]

On Fri, Jan 15, 2010 at 11:41:15PM -0600, Matt Mackall wrote:
> I've got a board here with SPI, NOR, and NAND flash devices and I've
> just run into a namespace collision on flash_platform_data from

The one in arch/arm/include/asm/mach/flash.h is designed to have great
appeal and flexibility across different platforms, and indeed we have
at least 70 users across six different MTD NOR flash drivers and two
MTD NAND drivers.

If anything, I believe that this header should move into linux/mtd/
and become a standard structure for platforms to communicate their
requirements to flash drivers.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

Re: flash_platform_data namespace collision

[Matt Mackall]

On Sat, 2010-01-16 at 11:04 +0000, Russell King wrote:
> On Fri, Jan 15, 2010 at 11:41:15PM -0600, Matt Mackall wrote:
> > I've got a board here with SPI, NOR, and NAND flash devices and I've
> > just run into a namespace collision on flash_platform_data from
> 
> The one in arch/arm/include/asm/mach/flash.h is designed to have great
> appeal and flexibility across different platforms, and indeed we have
> at least 70 users across six different MTD NOR flash drivers and two
> MTD NAND drivers.
> 
> If anything, I believe that this header should move into linux/mtd/
> and become a standard structure for platforms to communicate their
> requirements to flash drivers.

Yeah, I think this is probably the way to go. Davids, any objections?

-- 
http://selenic.com : development and support for Mercurial and Linux

Re: flash_platform_data namespace collision

[David Brownell]

On Saturday 16 January 2010, Matt Mackall wrote:
> On Sat, 2010-01-16 at 11:04 +0000, Russell King wrote:
> > On Fri, Jan 15, 2010 at 11:41:15PM -0600, Matt Mackall wrote:
> > > I've got a board here with SPI, NOR, and NAND flash devices and I've
> > > just run into a namespace collision on flash_platform_data from
> > 
> > The one in arch/arm/include/asm/mach/flash.h is designed to have great
> > appeal and flexibility across different platforms, and indeed we have
> > at least 70 users across six different MTD NOR flash drivers and two
> > MTD NAND drivers.

Yet it doesn't do what's needed for SPI flash (identify the chip type,
when it can't probed); and for that application none of those methods
are useful (and their slots are just wasted/confusing space).


> > If anything, I believe that this header should move into linux/mtd/
> > and become a standard structure for platforms to communicate their
> > requirements to flash drivers.
> 
> Yeah, I think this is probably the way to go. Davids, any objections?

I had similar thoughts when I first happened across that structure.

But such a move wouldn't resolve $SUBJECT ... which is IMO best addressed
by the obvious rename of the one to spi_flash_platform_data.

- dave