* [PATCH] Staging: dream: camera: msm_camera: fix coding style issues
@ 2010-02-11 18:47 Chihau Chau
2010-02-23 16:28 ` Pavel Machek
0 siblings, 1 reply; 2+ messages in thread
From: Chihau Chau @ 2010-02-11 18:47 UTC (permalink / raw)
To: gregkh, pavel; +Cc: devel, linux-kernel, Chihau Chau
From: Chihau Chau <chihau@gmail.com>
This fixes some coding style issues like to use __func__ instead
__FUNCTION__, "foo *bar" instead "foo* bar" and a initial comment with
"/* */" instead "//"
Signed-off-by: Chihau Chau <chihau@gmail.com>
---
drivers/staging/dream/camera/msm_camera.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dream/camera/msm_camera.c b/drivers/staging/dream/camera/msm_camera.c
index 7d93877..4f808dc 100644
--- a/drivers/staging/dream/camera/msm_camera.c
+++ b/drivers/staging/dream/camera/msm_camera.c
@@ -2,7 +2,7 @@
* Copyright (C) 2008-2009 QUALCOMM Incorporated.
*/
-//FIXME: most allocations need not be GFP_ATOMIC
+/* FIXME: most allocations need not be GFP_ATOMIC */
/* FIXME: management of mutexes */
/* FIXME: msm_pmem_region_lookup return values */
/* FIXME: way too many copy to/from user */
@@ -361,7 +361,7 @@ static int __msm_get_frame(struct msm_sync *sync,
if (!frame->buffer) {
pr_err("%s: cannot get frame, invalid lookup address "
"y=%x cbcr=%x offset=%d\n",
- __FUNCTION__,
+ __func__,
pphy->y_phy,
pphy->cbcr_phy,
frame->y_off);
@@ -455,7 +455,7 @@ static int msm_disable_vfe(struct msm_sync *sync, void __user *arg)
return rc;
}
-static struct msm_queue_cmd* __msm_control(struct msm_sync *sync,
+static struct msm_queue_cmd *__msm_control(struct msm_sync *sync,
struct msm_control_device_queue *queue,
struct msm_queue_cmd *qcmd,
int timeout)
--
1.5.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: dream: camera: msm_camera: fix coding style issues
2010-02-11 18:47 [PATCH] Staging: dream: camera: msm_camera: fix coding style issues Chihau Chau
@ 2010-02-23 16:28 ` Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2010-02-23 16:28 UTC (permalink / raw)
To: Chihau Chau; +Cc: gregkh, devel, linux-kernel
On Thu 2010-02-11 15:47:47, Chihau Chau wrote:
> From: Chihau Chau <chihau@gmail.com>
>
> This fixes some coding style issues like to use __func__ instead
> __FUNCTION__, "foo *bar" instead "foo* bar" and a initial comment with
> "/* */" instead "//"
>
> Signed-off-by: Chihau Chau <chihau@gmail.com>
> ---
> drivers/staging/dream/camera/msm_camera.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/dream/camera/msm_camera.c b/drivers/staging/dream/camera/msm_camera.c
> index 7d93877..4f808dc 100644
> --- a/drivers/staging/dream/camera/msm_camera.c
> +++ b/drivers/staging/dream/camera/msm_camera.c
> @@ -2,7 +2,7 @@
> * Copyright (C) 2008-2009 QUALCOMM Incorporated.
> */
>
> -//FIXME: most allocations need not be GFP_ATOMIC
> +/* FIXME: most allocations need not be GFP_ATOMIC */
> /* FIXME: management of mutexes */
> /* FIXME: msm_pmem_region_lookup return values */
> /* FIXME: way too many copy to/from user */
> @@ -361,7 +361,7 @@ static int __msm_get_frame(struct msm_sync *sync,
> if (!frame->buffer) {
> pr_err("%s: cannot get frame, invalid lookup address "
> "y=%x cbcr=%x offset=%d\n",
> - __FUNCTION__,
> + __func__,
> pphy->y_phy,
> pphy->cbcr_phy,
> frame->y_off);
> @@ -455,7 +455,7 @@ static int msm_disable_vfe(struct msm_sync *sync, void __user *arg)
> return rc;
> }
>
> -static struct msm_queue_cmd* __msm_control(struct msm_sync *sync,
> +static struct msm_queue_cmd *__msm_control(struct msm_sync *sync,
> struct msm_control_device_queue *queue,
> struct msm_queue_cmd *qcmd,
> int timeout)
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-23 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-11 18:47 [PATCH] Staging: dream: camera: msm_camera: fix coding style issues Chihau Chau
2010-02-23 16:28 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).