From: David Miller <davem@davemloft.net>
To: fujita.tomonori@lab.ntt.co.jp
Cc: hancockrwd@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
bzolnier@gmail.com
Subject: Re: [PATCH RFC] fix problems with NETIF_F_HIGHDMA in networking drivers v2
Date: Thu, 25 Mar 2010 20:35:20 -0700 (PDT) [thread overview]
Message-ID: <20100325.203520.234306178.davem@davemloft.net> (raw)
In-Reply-To: <20100326123250A.fujita.tomonori@lab.ntt.co.jp>
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Fri, 26 Mar 2010 12:33:12 +0900
> On Thu, 25 Mar 2010 19:03:37 -0600
> Robert Hancock <hancockrwd@gmail.com> wrote:
>
>> This seems like it could be a reasonable approach. The only thing is
>> that in this code you're returning 1 if the parent device has no DMA
>> mask set. Wouldn't it make more sense to return 0 in this case? I'm
>> assuming that in that situation it's a virtual device not backed by
>> any hardware and there should be no DMA mask restriction...
>
> I chose the safer option because I don't know enough how net_device
> structure is used. If returning zero in such case is always safe, it's
> fine by me. any example of such virtual device driver?
Like Fujita I'd rather play it safe here.
Even for virtual devices, DMA information up to the root bus
ought to be sane.
next prev parent reply other threads:[~2010-03-26 3:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 2:55 [PATCH RFC] fix problems with NETIF_F_HIGHDMA in networking drivers v2 Robert Hancock
2010-03-04 4:58 ` FUJITA Tomonori
2010-03-26 1:03 ` Robert Hancock
2010-03-26 3:33 ` FUJITA Tomonori
2010-03-26 3:35 ` David Miller [this message]
2010-03-31 8:35 ` FUJITA Tomonori
2010-04-02 2:53 ` David Miller
2010-03-10 20:17 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325.203520.234306178.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bzolnier@gmail.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hancockrwd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).