From: Roland Dreier <rdreier@cisco.com>
To: Robert Hancock <hancockrwd@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Linux-usb <linux-usb@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH RFC] fix problems with NETIF_F_HIGHDMA in networking drivers v2
Date: Wed, 10 Mar 2010 12:17:00 -0800 [thread overview]
Message-ID: <adar5nshqyr.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <4B8F213B.40603@gmail.com> (Robert Hancock's message of "Wed, 03 Mar 2010 20:55:55 -0600")
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index df3eb8c..53be462 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -1058,7 +1058,7 @@ static void ipoib_setup(struct net_device *dev)
> dev->type = ARPHRD_INFINIBAND;
> dev->tx_queue_len = ipoib_sendq_size * 2;
> dev->features = (NETIF_F_VLAN_CHALLENGED |
> - NETIF_F_HIGHDMA);
> + NETIF_F_DMA_HIGH);
> dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
>
> memcpy(dev->broadcast, ipv4_bcast_addr, INFINIBAND_ALEN);
Been meaning to mention this for a bit, but ipoib is capable of handling
any DMA address, so if I understand your patch correctly, this can be
NETIF_F_DMA_64BIT instead of just DMA_HIGH.
--
Roland Dreier <rolandd@cisco.com>
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
prev parent reply other threads:[~2010-03-10 20:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 2:55 [PATCH RFC] fix problems with NETIF_F_HIGHDMA in networking drivers v2 Robert Hancock
2010-03-04 4:58 ` FUJITA Tomonori
2010-03-26 1:03 ` Robert Hancock
2010-03-26 3:33 ` FUJITA Tomonori
2010-03-26 3:35 ` David Miller
2010-03-31 8:35 ` FUJITA Tomonori
2010-04-02 2:53 ` David Miller
2010-03-10 20:17 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adar5nshqyr.fsf@roland-alpha.cisco.com \
--to=rdreier@cisco.com \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=hancockrwd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).