linux-next: build warning after merge of the i2c tree

linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

Hi Jean,

After merging the ii2c tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/i2c/i2c-core.c:159: warning: 'i2c_legacy_suspend' defined but not used
drivers/i2c/i2c-core.c:172: warning: 'i2c_legacy_resume' defined but not used

Introduced by commit 592b0bd0324728fe0aca823951eba06a9494c2f9 ("i2c: Fix
bus-level power management callbacks").  These routines are only called
if CONFIG_PM_SLEEP is defined.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Jean Delvare]

Hi Stephen,

On Mon, 29 Mar 2010 10:54:39 +1100, Stephen Rothwell wrote:
> Hi Jean,
> 
> After merging the ii2c tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/i2c/i2c-core.c:159: warning: 'i2c_legacy_suspend' defined but not used
> drivers/i2c/i2c-core.c:172: warning: 'i2c_legacy_resume' defined but not used
> 
> Introduced by commit 592b0bd0324728fe0aca823951eba06a9494c2f9 ("i2c: Fix
> bus-level power management callbacks").  These routines are only called
> if CONFIG_PM_SLEEP is defined.

Err, sorry. I noticed the problem and fixed it some days ago, but
forgot to refresh the patch before pushing it to you. This is fixed
now, thanks for the notice.

-- 
Jean Delvare

Re: linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

Hi Jean,

On Mon, 29 Mar 2010 15:21:55 +0200 Jean Delvare <khali@linux-fr.org> wrote:
>
> Err, sorry. I noticed the problem and fixed it some days ago, but
> forgot to refresh the patch before pushing it to you. This is fixed
> now, thanks for the notice.

Thanks. 2 less warnings ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Hi all,

After merging the i2c tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
  208 |  struct device *pdev = vdev->dev.parent;
      |                 ^~~~

Introduced by commit

  8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Jie Deng]

On 2021/8/18 14:29, Stephen Rothwell wrote:
> Hi all,
>
> After merging the i2c tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
> drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
>    208 |  struct device *pdev = vdev->dev.parent;
>        |                 ^~~~
>
> Introduced by commit
>
>    8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")


Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' 
was used in line 237.

https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31

Re: linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

Hi Jie,

On Wed, 18 Aug 2021 14:54:12 +0800 Jie Deng <jie.deng@intel.com> wrote:
>
> On 2021/8/18 14:29, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the i2c tree, today's linux-next build (powerpc
> > allyesconfig) produced this warning:
> >
> > drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
> > drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
> >    208 |  struct device *pdev = vdev->dev.parent;
> >        |                 ^~~~
> >
> > Introduced by commit
> >
> >    8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")  
> 
> Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' was used in line 237.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31
> 

When CONFIG_ACPI is not set, ACPI_COMPANION{,_SET} do not use their arguments.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Jie Deng]

On 2021/8/18 15:04, Stephen Rothwell wrote:
> Hi Jie,
>
> On Wed, 18 Aug 2021 14:54:12 +0800 Jie Deng <jie.deng@intel.com> wrote:
>> On 2021/8/18 14:29, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the i2c tree, today's linux-next build (powerpc
>>> allyesconfig) produced this warning:
>>>
>>> drivers/i2c/busses/i2c-virtio.c: In function 'virtio_i2c_probe':
>>> drivers/i2c/busses/i2c-virtio.c:208:17: warning: unused variable 'pdev' [-Wunused-variable]
>>>     208 |  struct device *pdev = vdev->dev.parent;
>>>         |                 ^~~~
>>>
>>> Introduced by commit
>>>
>>>     8fb12751ac78 ("i2c: virtio: add a virtio i2c frontend driver")
>> Why we have this warning ? In commit 8fb12751ac78, the variable 'pdev' was used in line 237.
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git/commit/?h=i2c/for-next&id=8fb12751ac78d0a4ba3c604496ffc8dcd1bd6c31
>>
> When CONFIG_ACPI is not set, ACPI_COMPANION{,_SET} do not use their arguments.


Thanks Stephen. I will send an additional patch to fix it.

linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

Hi all,

After merging the i2c tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/i2c/busses/i2c-designware-master.c: In function 'i2c_dw_init_recovery_info':
drivers/i2c/busses/i2c-designware-master.c:658:6: warning: unused variable 'r' [-Wunused-variable]
  int r;
      ^

Introduced by commit

  33eb09a02e8d ("i2c: designware: make use of devm_gpiod_get_optional")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hello Wolfram,

On Fri, Aug 02, 2019 at 01:21:23PM +1000, Stephen Rothwell wrote:
> After merging the i2c tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/i2c/busses/i2c-designware-master.c: In function 'i2c_dw_init_recovery_info':
> drivers/i2c/busses/i2c-designware-master.c:658:6: warning: unused variable 'r' [-Wunused-variable]
>   int r;
>       ^
> 
> Introduced by commit
> 
>   33eb09a02e8d ("i2c: designware: make use of devm_gpiod_get_optional")

The obvious fix is to just remove this variable. Should I send a new
patch, or do you fix up locally?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

Hi Wolfram,

After merging the i2c tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/media/dvb-frontends/tua6100.c: In function 'tua6100_set_params':
drivers/media/dvb-frontends/tua6100.c:71: warning: "_P" redefined
 #define _P 32
 
In file included from include/acpi/platform/aclinux.h:54,
                 from include/acpi/platform/acenv.h:152,
                 from include/acpi/acpi.h:22,
                 from include/linux/acpi.h:21,
                 from include/linux/i2c.h:17,
                 from drivers/media/dvb-frontends/tua6100.h:22,
                 from drivers/media/dvb-frontends/tua6100.c:24:
include/linux/ctype.h:14: note: this is the location of the previous definition
 #define _P 0x10 /* punct */

Exposed by commit

  5213d7efc8ec ("i2c: acpi: export i2c_acpi_find_adapter_by_handle")

Since that included <linux/acpi.h> from <linux/i2c.h>

Originally introduced by commit

  00be2e7c6415 ("V4L/DVB (4606): Add driver for TUA6100")

The _P in <linux/ctype.h> has existed since before git.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On Tue, Jun 11, 2019 at 10:25:28AM +1000, Stephen Rothwell wrote:
> Hi Wolfram,
> 
> After merging the i2c tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/media/dvb-frontends/tua6100.c: In function 'tua6100_set_params':
> drivers/media/dvb-frontends/tua6100.c:71: warning: "_P" redefined
>  #define _P 32
>  
> In file included from include/acpi/platform/aclinux.h:54,
>                  from include/acpi/platform/acenv.h:152,
>                  from include/acpi/acpi.h:22,
>                  from include/linux/acpi.h:21,
>                  from include/linux/i2c.h:17,
>                  from drivers/media/dvb-frontends/tua6100.h:22,
>                  from drivers/media/dvb-frontends/tua6100.c:24:
> include/linux/ctype.h:14: note: this is the location of the previous definition
>  #define _P 0x10 /* punct */
> 
> Exposed by commit
> 
>   5213d7efc8ec ("i2c: acpi: export i2c_acpi_find_adapter_by_handle")
> 
> Since that included <linux/acpi.h> from <linux/i2c.h>
> 
> Originally introduced by commit
> 
>   00be2e7c6415 ("V4L/DVB (4606): Add driver for TUA6100")
> 
> The _P in <linux/ctype.h> has existed since before git.

I suggest to fix the driver by adding a TUA6100_ prefix to the defines.
I can cook up a patch for that.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Mauro Carvalho Chehab]

Em Wed, 12 Jun 2019 10:19:29 +0200
Wolfram Sang <wsa@the-dreams.de> escreveu:

> On Tue, Jun 11, 2019 at 10:25:28AM +1000, Stephen Rothwell wrote:
> > Hi Wolfram,
> > 
> > After merging the i2c tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > drivers/media/dvb-frontends/tua6100.c: In function 'tua6100_set_params':
> > drivers/media/dvb-frontends/tua6100.c:71: warning: "_P" redefined
> >  #define _P 32
> >  
> > In file included from include/acpi/platform/aclinux.h:54,
> >                  from include/acpi/platform/acenv.h:152,
> >                  from include/acpi/acpi.h:22,
> >                  from include/linux/acpi.h:21,
> >                  from include/linux/i2c.h:17,
> >                  from drivers/media/dvb-frontends/tua6100.h:22,
> >                  from drivers/media/dvb-frontends/tua6100.c:24:
> > include/linux/ctype.h:14: note: this is the location of the previous definition
> >  #define _P 0x10 /* punct */
> > 
> > Exposed by commit
> > 
> >   5213d7efc8ec ("i2c: acpi: export i2c_acpi_find_adapter_by_handle")
> > 
> > Since that included <linux/acpi.h> from <linux/i2c.h>
> > 
> > Originally introduced by commit
> > 
> >   00be2e7c6415 ("V4L/DVB (4606): Add driver for TUA6100")
> > 
> > The _P in <linux/ctype.h> has existed since before git.  
> 
> I suggest to fix the driver by adding a TUA6100_ prefix to the defines.
> I can cook up a patch for that.
> 

That entire use of _P, _R and _ri looks weird into my eyes. The code there
do things like:

#define _P 32

...

        if (_P == 64)
                reg1[1] |= 0x40;


It sounds to me that _P and _R are actually some sort of setup
with depends on how the device is wired. 

A quick read on its datasheet at page 19 - downloaded from:

	http://www.datasheetcatalog.com/datasheets_pdf/T/U/A/6/TUA6100.shtml

Shows that:
	P:  divide ratio of the prescaler.
	R:  divide ratio of the R-counter.
	ri: reference frequency input (XTAL osc).

IMO, the right fix would be to change struct tua6100_priv, in order to
add those  parameters, and initialize them with the current values
at tua6100_attach.

That would allow changing those values during device initialization,
in the case we ever need to support a hardware with the same chipset,
with, for example, a different XTAL.

I'll work on a patch to address it.

Thanks,
Mauro

Re: linux-next: build warning after merge of the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi Mauro,

> That entire use of _P, _R and _ri looks weird into my eyes. The code there

Yes.

> do things like:
> 
> #define _P 32
> 
> ...
> 
>         if (_P == 64)
>                 reg1[1] |= 0x40;

Yup, I saw this, too, but didn't feel like refactoring the driver.
Thanks for stepping up!

> I'll work on a patch to address it.

OK, so that means I should send my pull request after yours in the next
merge window? To avoid the build breakage?

Kind regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Mauro Carvalho Chehab]

Em Wed, 12 Jun 2019 13:09:04 +0200
Wolfram Sang <wsa@the-dreams.de> escreveu:

> Hi Mauro,
> 
> > That entire use of _P, _R and _ri looks weird into my eyes. The code there  
> 
> Yes.
> 
> > do things like:
> > 
> > #define _P 32
> > 
> > ...
> > 
> >         if (_P == 64)
> >                 reg1[1] |= 0x40;  
> 
> Yup, I saw this, too, but didn't feel like refactoring the driver.
> Thanks for stepping up!
> 
> > I'll work on a patch to address it.  
> 
> OK, so that means I should send my pull request after yours in the next
> merge window? To avoid the build breakage?

Either that or you can apply my patch on your tree before the
patch that caused the breakage. 

Just let me know what works best for you.

> 
> Kind regards,
> 
>    Wolfram
> 



Thanks,
Mauro

Re: linux-next: build warning after merge of the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]


> > OK, so that means I should send my pull request after yours in the next
> > merge window? To avoid the build breakage?
> 
> Either that or you can apply my patch on your tree before the
> patch that caused the breakage. 
> 
> Just let me know what works best for you.

Hmm, the offending patch is already in -next and I don't rebase my tree.
So, I guess it's the merge window dependency then.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Mauro Carvalho Chehab]

Em Wed, 12 Jun 2019 14:04:39 +0200
Wolfram Sang <wsa@the-dreams.de> escreveu:

> > > OK, so that means I should send my pull request after yours in the next
> > > merge window? To avoid the build breakage?  
> > 
> > Either that or you can apply my patch on your tree before the
> > patch that caused the breakage. 
> > 
> > Just let me know what works best for you.  
> 
> Hmm, the offending patch is already in -next and I don't rebase my tree.
> So, I guess it's the merge window dependency then.
> 
Ok, I'll merge it through my tree then.

Thanks,
Mauro

Re: linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

Hi all,

On Wed, 12 Jun 2019 09:32:29 -0300 Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
>
> Em Wed, 12 Jun 2019 14:04:39 +0200
> Wolfram Sang <wsa@the-dreams.de> escreveu:
> 
> > > > OK, so that means I should send my pull request after yours in the next
> > > > merge window? To avoid the build breakage?    
> > > 
> > > Either that or you can apply my patch on your tree before the
> > > patch that caused the breakage. 
> > > 
> > > Just let me know what works best for you.    
> > 
> > Hmm, the offending patch is already in -next and I don't rebase my tree.
> > So, I guess it's the merge window dependency then.
> >   
> Ok, I'll merge it through my tree then.

It should go into the i2c tree (since that is where the *warning* was
introduced).  It is only a warning and there won't be many patches
between the patch that introduced the warning and this one that fixes
it.  This patch could then have a Fixes tag that makes sense i.e. it
will reference a previous commit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]

On Wed, Jun 12, 2019 at 11:15:35PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 12 Jun 2019 09:32:29 -0300 Mauro Carvalho Chehab <mchehab@infradead.org> wrote:
> >
> > Em Wed, 12 Jun 2019 14:04:39 +0200
> > Wolfram Sang <wsa@the-dreams.de> escreveu:
> > 
> > > > > OK, so that means I should send my pull request after yours in the next
> > > > > merge window? To avoid the build breakage?    
> > > > 
> > > > Either that or you can apply my patch on your tree before the
> > > > patch that caused the breakage. 
> > > > 
> > > > Just let me know what works best for you.    
> > > 
> > > Hmm, the offending patch is already in -next and I don't rebase my tree.
> > > So, I guess it's the merge window dependency then.
> > >   
> > Ok, I'll merge it through my tree then.
> 
> It should go into the i2c tree (since that is where the *warning* was
> introduced).  It is only a warning and there won't be many patches
> between the patch that introduced the warning and this one that fixes
> it.  This patch could then have a Fixes tag that makes sense i.e. it
> will reference a previous commit.

I can apply the patch to my i2c/for-next branch, but not to my
i2c/for-5.3 branch (which I merge into i2c/for-next). This way, the
warning will go away, but the media patch still goes to Linus via the
media tree. Is that suitable for you?



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

Hi Wolfram,

After merging the i2c tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined
 #define DEBUG
 ^
<command-line>:0:0: note: this is the location of the previous definition

Introduced by commit

  6c42778780c4 ("i2c: stub: use pr_fmt")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

Hi Wolfram,

On Mon, 5 Jun 2017 11:11:31 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the i2c tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined
>  #define DEBUG
>  ^
> <command-line>:0:0: note: this is the location of the previous definition
> 
> Introduced by commit
> 
>   6c42778780c4 ("i2c: stub: use pr_fmt")

I am still getting this ...

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the i2c tree

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

> > drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined
> >  #define DEBUG
> >  ^
> > <command-line>:0:0: note: this is the location of the previous definition
> > 
> > Introduced by commit
> > 
> >   6c42778780c4 ("i2c: stub: use pr_fmt")
> 
> I am still getting this ...

Sorry, that slipped through the cracks, will fix today!

Thanks for the reminder.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

Hi Wolfram,

On Thu, 15 Jun 2017 09:02:44 +0200 Wolfram Sang <wsa@the-dreams.de> wrote:
>
> > > drivers/i2c/i2c-stub.c:18:0: warning: "DEBUG" redefined
> > >  #define DEBUG
> > >  ^
> > > <command-line>:0:0: note: this is the location of the previous definition
> > > 
> > > Introduced by commit
> > > 
> > >   6c42778780c4 ("i2c: stub: use pr_fmt")  
> > 
> > I am still getting this ...  
> 
> Sorry, that slipped through the cracks, will fix today!

Thanks.

> Thanks for the reminder.

I am trying to be more proactive with these things.
-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

Hi Wolfram,

After merging the i2c tree, today's linux-next build (powerpc
ppc64_defconfig, x86_64 allmodconfig and arm multi_v7_defconfig) produced
this warning:

drivers/video/Kconfig:42:error: recursive dependency detected!
drivers/video/Kconfig:42:	symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_TEGRA_FBDEV
drivers/gpu/drm/tegra/Kconfig:18:	symbol DRM_TEGRA_FBDEV depends on DRM_TEGRA
drivers/gpu/drm/tegra/Kconfig:1:	symbol DRM_TEGRA depends on RESET_CONTROLLER
drivers/reset/Kconfig:4:	symbol RESET_CONTROLLER is selected by I2C_MV64XXX
drivers/i2c/busses/Kconfig:528:	symbol I2C_MV64XXX depends on I2C
drivers/i2c/Kconfig:5:	symbol I2C is selected by FB_DDC
drivers/video/Kconfig:92:	symbol FB_DDC is selected by FB_CYBER2000_DDC
drivers/video/Kconfig:386:	symbol FB_CYBER2000_DDC depends on FB_CYBER2000
drivers/video/Kconfig:374:	symbol FB_CYBER2000 depends on FB

Introduced by commit 370136bc67c3 ("i2c: mv64xxx: Add reset deassert call").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the i2c tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hi Jean,

After merging the i2c tree, today's linux-next build (powerpc
ppc64_defconfig) produced warnings like this:

In file included from include/linux/bitops.h:17,
                 from include/linux/kernel.h:15,
                 from drivers/i2c/i2c-boardinfo.c:19:
arch/powerpc/include/asm/bitops.h:226: warning: declaration of 'ffs' shadows a built-in function

The x86_64 allmodconfig produces similar:

In file included from include/linux/bitops.h:17,
                 from include/linux/kernel.h:15,
                 from next/drivers/i2c/i2c-boardinfo.c:19:
arch/x86/include/asm/bitops.h:395: warning: declaration of 'ffs' shadows a built-in function

Exposed by commit fa4f62e9f3a85490aebe8857e2208c37da851ce3 ("i2c: Build
core and algo drivers with -Wshadow").

Jean, I realise that these warnings are not something your tree has
added, just that you have exposed them.  They are a bit annoying,
though.  I am using gcc v4.4.3.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warning after merge of the i2c tree

[Jean Delvare]

On Wed, 17 Feb 2010 11:38:55 +1100, Stephen Rothwell wrote:
> Hi Jean,
> 
> After merging the i2c tree, today's linux-next build (powerpc
> ppc64_defconfig) produced warnings like this:
> 
> In file included from include/linux/bitops.h:17,
>                  from include/linux/kernel.h:15,
>                  from drivers/i2c/i2c-boardinfo.c:19:
> arch/powerpc/include/asm/bitops.h:226: warning: declaration of 'ffs' shadows a built-in function
> 
> The x86_64 allmodconfig produces similar:
> 
> In file included from include/linux/bitops.h:17,
>                  from include/linux/kernel.h:15,
>                  from next/drivers/i2c/i2c-boardinfo.c:19:
> arch/x86/include/asm/bitops.h:395: warning: declaration of 'ffs' shadows a built-in function
> 
> Exposed by commit fa4f62e9f3a85490aebe8857e2208c37da851ce3 ("i2c: Build
> core and algo drivers with -Wshadow").
> 
> Jean, I realise that these warnings are not something your tree has
> added, just that you have exposed them.  They are a bit annoying,
> though.  I am using gcc v4.4.3.

Oh well. I had the hope that at least the header files were
Wshadow-compliant so it could be enabled for selected source files. Not
getting any warning on my own system when I tried, I thought it was
fine... If it is not, then I'll just remove this patch from my tree.
Sorry for the noise and thanks for reporting.

-- 
Jean Delvare