linux-next: build failure after merge of the final tree (hid tree related)

linux-next: build failure after merge of the final tree (hid tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

Hi Jiri,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/hid/hid-picolcd.c: In function 'picolcd_debug_reset_write':
drivers/hid/hid-picolcd.c:1343: error: implicit declaration of function 'copy_from_user'
drivers/hid/hid-picolcd.c: In function 'picolcd_debug_eeprom_read':
drivers/hid/hid-picolcd.c:1407: error: implicit declaration of function 'copy_to_user'

Caused by commit 9bbf2b98ba11d00bd73e3254e15cfe17ccaff6ba ("HID: add
experimental access to PicoLCD device's EEPROM and FLASH").  Using copy_
{to,from}_user requires the include of linux/uaccess.h.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the final tree (hid tree related)

[Jiri Kosina]

On Thu, 1 Apr 2010, Stephen Rothwell wrote:

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/hid/hid-picolcd.c: In function 'picolcd_debug_reset_write':
> drivers/hid/hid-picolcd.c:1343: error: implicit declaration of function 'copy_from_user'
> drivers/hid/hid-picolcd.c: In function 'picolcd_debug_eeprom_read':
> drivers/hid/hid-picolcd.c:1407: error: implicit declaration of function 'copy_to_user'
> 
> Caused by commit 9bbf2b98ba11d00bd73e3254e15cfe17ccaff6ba ("HID: add
> experimental access to PicoLCD device's EEPROM and FLASH").  Using copy_
> {to,from}_user requires the include of linux/uaccess.h.
> 
> I have reverted that commit for today.

Hmm, on which arch did this bomb out? I wonder why it is building fine for 
me.

Anyway, I have added the include, as it is obviously correct(tm), thanks 
for reporting it.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

Re: linux-next: build failure after merge of the final tree (hid tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

Hi Jiri,

On Thu, 1 Apr 2010 08:18:43 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:
>
> On Thu, 1 Apr 2010, Stephen Rothwell wrote:
> 
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> > 
> > drivers/hid/hid-picolcd.c: In function 'picolcd_debug_reset_write':
> > drivers/hid/hid-picolcd.c:1343: error: implicit declaration of function 'copy_from_user'
> > drivers/hid/hid-picolcd.c: In function 'picolcd_debug_eeprom_read':
> > drivers/hid/hid-picolcd.c:1407: error: implicit declaration of function 'copy_to_user'
> > 
> > Caused by commit 9bbf2b98ba11d00bd73e3254e15cfe17ccaff6ba ("HID: add
> > experimental access to PicoLCD device's EEPROM and FLASH").  Using copy_
> > {to,from}_user requires the include of linux/uaccess.h.
> > 
> > I have reverted that commit for today.
> 
> Hmm, on which arch did this bomb out? I wonder why it is building fine for 
> me.

PowerPC (see above).  It could also be some interaction with another tree
in linux-next.

> Anyway, I have added the include, as it is obviously correct(tm), thanks 
> for reporting it.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build failure after merge of the final tree (hid tree related)

[Bruno Prémont]

Hi Jiri, Stephen,

Wondering why x86 (32bit and 64bit) does not need to include the
header but other arches (at least powerpc) need it.

Any idea via which header linux/uaccess.h gets included on x86?
If nobody has checked by the time I get home I will determine that.

Thanks,
Bruno


On Thu, 1 Apr 2010 18:35:30 Stephen Rothwell wrote:
> Hi Jiri,
> 
> On Thu, 1 Apr 2010 08:18:43 +0200 (CEST) Jiri Kosina
> <jkosina@suse.cz> wrote:
> >
> > On Thu, 1 Apr 2010, Stephen Rothwell wrote:
> > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > > 
> > > drivers/hid/hid-picolcd.c: In function
> > > 'picolcd_debug_reset_write': drivers/hid/hid-picolcd.c:1343:
> > > error: implicit declaration of function 'copy_from_user'
> > > drivers/hid/hid-picolcd.c: In function
> > > 'picolcd_debug_eeprom_read': drivers/hid/hid-picolcd.c:1407:
> > > error: implicit declaration of function 'copy_to_user'
> > > 
> > > Caused by commit 9bbf2b98ba11d00bd73e3254e15cfe17ccaff6ba ("HID:
> > > add experimental access to PicoLCD device's EEPROM and FLASH").
> > > Using copy_ {to,from}_user requires the include of
> > > linux/uaccess.h.
> > > 
> > > I have reverted that commit for today.
> > 
> > Hmm, on which arch did this bomb out? I wonder why it is building
> > fine for me.
> 
> PowerPC (see above).  It could also be some interaction with another
> tree in linux-next.
> 
> > Anyway, I have added the include, as it is obviously correct(tm),
> > thanks for reporting it.
> 
> Thanks.
> 

Re: linux-next: build failure after merge of the final tree (hid tree related)

[Bruno Prémont]

On Thu, 01 April 2010 Bruno Prémont <bonbons@linux-vserver.org> wrote:
> Hi Jiri, Stephen,
> 
> Wondering why x86 (32bit and 64bit) does not need to include the
> header but other arches (at least powerpc) need it.
> 
> Any idea via which header linux/uaccess.h gets included on x86?
> If nobody has checked by the time I get home I will determine that.

Here is the include path for x86:
included arch/x86/include/asm/uaccess.h
    from arch/x86/include/asm/sections.h:5,
    from arch/x86/include/asm/hw_irq.h:26,
    from include/linux/irq.h:233,
    from arch/x86/include/asm/hardirq.h:5,
    from include/linux/hardirq.h:10,
    from include/linux/interrupt.h:12,
    from include/linux/usb.h:15,
    from drivers/hid/hid-picolcd.c:26:

Wondering why there is such a difference for powerpc!

Thanks,
Bruno


> On Thu, 1 Apr 2010 18:35:30 Stephen Rothwell wrote:
> > Hi Jiri,
> > 
> > On Thu, 1 Apr 2010 08:18:43 +0200 (CEST) Jiri Kosina
> > <jkosina@suse.cz> wrote:
> > >
> > > On Thu, 1 Apr 2010, Stephen Rothwell wrote:
> > > 
> > > > After merging the final tree, today's linux-next build (powerpc
> > > > allyesconfig) failed like this:
> > > > 
> > > > drivers/hid/hid-picolcd.c: In function
> > > > 'picolcd_debug_reset_write': drivers/hid/hid-picolcd.c:1343:
> > > > error: implicit declaration of function 'copy_from_user'
> > > > drivers/hid/hid-picolcd.c: In function
> > > > 'picolcd_debug_eeprom_read': drivers/hid/hid-picolcd.c:1407:
> > > > error: implicit declaration of function 'copy_to_user'
> > > > 
> > > > Caused by commit 9bbf2b98ba11d00bd73e3254e15cfe17ccaff6ba ("HID:
> > > > add experimental access to PicoLCD device's EEPROM and FLASH").
> > > > Using copy_ {to,from}_user requires the include of
> > > > linux/uaccess.h.
> > > > 
> > > > I have reverted that commit for today.
> > > 
> > > Hmm, on which arch did this bomb out? I wonder why it is building
> > > fine for me.
> > 
> > PowerPC (see above).  It could also be some interaction with another
> > tree in linux-next.
> > 
> > > Anyway, I have added the include, as it is obviously correct(tm),
> > > thanks for reporting it.
> > 
> > Thanks.
> > 

linux-next: build failure after merge of the final tree (hid tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2076 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/hid/hid-picolcd_fb.c: In function 'picolcd_fb_destroy':
drivers/hid/hid-picolcd_fb.c:350:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
drivers/hid/hid-picolcd_fb.c: In function 'picolcd_init_framebuffer':
drivers/hid/hid-picolcd_fb.c:508:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
drivers/hid/hid-picolcd_fb.c:508:12: warning: assignment makes pointer from integer without a cast [enabled by default]

Caused by commit fabdbf2fd22f ("HID: picoLCD: split driver code") from
the hid tree.

I added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 16 Aug 2012 15:20:10 +1000
Subject: [PATCH] HID: using vmalloc() requires the include of vmalloc.h

Fixes thes build errors:

drivers/hid/hid-picolcd_fb.c: In function 'picolcd_fb_destroy':
drivers/hid/hid-picolcd_fb.c:350:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
drivers/hid/hid-picolcd_fb.c: In function 'picolcd_init_framebuffer':
drivers/hid/hid-picolcd_fb.c:508:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
drivers/hid/hid-picolcd_fb.c:508:12: warning: assignment makes pointer from integer without a cast [enabled by default]

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/hid/hid-picolcd_fb.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
index 4d8e22c..cf295c5 100644
--- a/drivers/hid/hid-picolcd_fb.c
+++ b/drivers/hid/hid-picolcd_fb.c
@@ -18,6 +18,7 @@
  ***************************************************************************/
 
 #include <linux/hid.h>
+#include <linux/vmalloc.h>
 #include "usbhid/usbhid.h"
 #include <linux/usb.h>
 
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (hid tree related)

[Jiri Kosina]

On Thu, 16 Aug 2012, Stephen Rothwell wrote:

> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/hid/hid-picolcd_fb.c: In function 'picolcd_fb_destroy':
> drivers/hid/hid-picolcd_fb.c:350:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> drivers/hid/hid-picolcd_fb.c: In function 'picolcd_init_framebuffer':
> drivers/hid/hid-picolcd_fb.c:508:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration]
> drivers/hid/hid-picolcd_fb.c:508:12: warning: assignment makes pointer from integer without a cast [enabled by default]
> 
> Caused by commit fabdbf2fd22f ("HID: picoLCD: split driver code") from
> the hid tree.

Hmm, seems config dependent, doesn't trigger here. Probably vmalloc.h gets 
sucked in some other way under certain config options.

Anyway I have now applied your patch Stephen, so you should be able to 
drop it from your pile.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: linux-next: build failure after merge of the final tree (hid tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi Jiri,

On Thu, 16 Aug 2012 12:05:57 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:
>
> Hmm, seems config dependent, doesn't trigger here. Probably vmalloc.h gets 
> sucked in some other way under certain config options.

That's why we have Rule 1 in Documentation/SubmitChecklist.

> Anyway I have now applied your patch Stephen, so you should be able to 
> drop it from your pile.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]