From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: michaelc@cs.wisc.edu
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
pjones@redhat.com, open-iscsi@googlegroups.com
Subject: Re: [PATCH 2/2] RFC: iscsi ibft: convert iscsi_ibft module to iscsi boot lib
Date: Mon, 12 Apr 2010 22:21:04 -0400 [thread overview]
Message-ID: <201004122221.05326.konrad@darnok.org> (raw)
In-Reply-To: <1271095578-4212-2-git-send-email-michaelc@cs.wisc.edu>
On Monday 12 April 2010 14:06:18 you wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
>
> This patch just converts the iscsi_ibft module to the
> iscsi boot sysfs lib module.
>
> This patch was made over the ibft-2.6 tree's ibft-1.03 branch:
> http://git.kernel.org/?p=linux/kernel/git/konrad/ibft-2.6.git;a=shortlog;h=
>refs/heads/ibft-1.03
>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
>
I've only two comments:
.. snip..
> /*
> + * Helper routiners to check to determine if the entry is valid
> + * in the proper iBFT structure.
> + */
> +static mode_t ibft_check_nic_for(void *data, int type)
> +{
> + struct ibft_kobject *entry = data;
> + struct ibft_nic *nic = entry->nic;
> + mode_t rc = 0;
> +
> + switch (type) {
> + case ISCSI_BOOT_ETH_INDEX:
> + case ISCSI_BOOT_ETH_FLAGS:
> + rc = 1;
Did you mean for that value?
> + break;
> + case ISCSI_BOOT_ETH_IP_ADDR:
> + if (memcmp(nic->ip_addr, nulls, sizeof(nic->ip_addr)))
> + rc = S_IRUGO;
> + break;
> + case ISCSI_BOOT_ETH_SUBNET_MASK:
> + if (nic->subnet_mask_prefix)
> + rc = S_IRUGO;
> + break;
> + case ISCSI_BOOT_ETH_ORIGIN:
> + rc = 1;
and this one as well?
next prev parent reply other threads:[~2010-04-13 2:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 18:06 [PATCH 1/2] RFC: iscsi ibft: separate ibft parsing from sysfs interface michaelc
2010-04-12 18:06 ` [PATCH 2/2] RFC: iscsi ibft: convert iscsi_ibft module to iscsi boot lib michaelc
2010-04-13 2:21 ` Konrad Rzeszutek Wilk [this message]
2010-04-13 2:32 ` Mike Christie
2010-04-13 2:36 ` Konrad Rzeszutek Wilk
2010-04-13 14:59 ` Peter Jones
2010-04-13 2:20 ` [PATCH 1/2] RFC: iscsi ibft: separate ibft parsing from sysfs interface Konrad Rzeszutek Wilk
2010-08-11 15:54 ` Randy Dunlap
2010-08-11 16:04 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004122221.05326.konrad@darnok.org \
--to=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).