From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Michal Hocko <mhocko@suse.cz>
Cc: Tony Vroon <tony@linx.net>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
linux-kernel@vger.kernel.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: commit 9630bdd9 changes behavior of the poweroff - bug?
Date: Tue, 13 Apr 2010 22:53:37 +0200 [thread overview]
Message-ID: <201004132253.37432.rjw@sisk.pl> (raw)
In-Reply-To: <20100413082756.GA5233@tiehlicka.suse.cz>
On Tuesday 13 April 2010, Michal Hocko wrote:
> On Tue 13-04-10 01:01:54, Rafael J. Wysocki wrote:
> > On Saturday 10 April 2010, Rafael J. Wysocki wrote:
> > > On Friday 09 April 2010, Tony Vroon wrote:
> > > > On Fri, 2010-04-09 at 22:42 +0200, Rafael J. Wysocki wrote:
> > > > > Please check if the patch below changes anything.
> > > > > drivers/acpi/wakeup.c | 4 ++--
> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > That didn't change the behaviour for me, sorry.
> > >
> > > Well, I would be sorry if it did, because the patch removed some useful code. :-)
> > >
> > > > (I made sure to go through a full power down session before trying the
> > > > patched kernel)
> > >
> > > Thanks for testing. So it looks like we don't disable the GPE during power off.
> > >
> > > I'll try to figure out what's going on, please stay tuned.
> >
> > Can you please check if the patch below changes the behavior?
>
> Unfortunately, it didn't help either (I have tried on top of the fresh
> rc4).
That gets really weird.
> > ---
> > drivers/acpi/wakeup.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > Index: linux-2.6/drivers/acpi/wakeup.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/acpi/wakeup.c
> > +++ linux-2.6/drivers/acpi/wakeup.c
> > @@ -63,17 +63,17 @@ void acpi_enable_wakeup_device(u8 sleep_
> > list_for_each_safe(node, next, &acpi_wakeup_device_list) {
> > struct acpi_device *dev =
> > container_of(node, struct acpi_device, wakeup_list);
> > + u8 action = ACPI_GPE_ENABLE;
Can you try to change the above to ACPI_GPE_DISABLE and retest, please?
> > if (!dev->wakeup.flags.valid)
> > continue;
> >
> > if ((!dev->wakeup.state.enabled && !dev->wakeup.prepare_count)
> > || sleep_state > (u32) dev->wakeup.sleep_state)
> > - continue;
> > + action = ACPI_GPE_DISABLE;
> >
> > - /* The wake-up power should have been enabled already. */
> > acpi_set_gpe(dev->wakeup.gpe_device, dev->wakeup.gpe_number,
> > - ACPI_GPE_ENABLE);
> > + action);
> > }
> > }
Rafael
next prev parent reply other threads:[~2010-04-13 19:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 13:39 commit 9630bdd9 changes behavior of the poweroff - bug? Michal Hocko
2010-04-01 13:45 ` Matthew Garrett
2010-04-01 13:53 ` Michal Hocko
2010-04-02 19:31 ` Rafael J. Wysocki
2010-04-07 7:34 ` Michal Hocko
2010-04-07 19:49 ` Rafael J. Wysocki
2010-04-08 9:49 ` Michal Hocko
2010-04-08 20:43 ` Rafael J. Wysocki
2010-04-08 22:37 ` Tony Vroon
2010-04-08 22:54 ` Rafael J. Wysocki
2010-04-09 20:42 ` Rafael J. Wysocki
2010-04-09 21:20 ` Tony Vroon
2010-04-10 19:36 ` Rafael J. Wysocki
2010-04-12 23:01 ` Rafael J. Wysocki
2010-04-13 8:27 ` Michal Hocko
2010-04-13 20:53 ` Rafael J. Wysocki [this message]
2010-04-14 7:58 ` Michal Hocko
2010-04-16 18:00 ` Rafael J. Wysocki
2010-04-19 11:59 ` Michal Hocko
2010-04-19 15:19 ` Rafael J. Wysocki
2010-04-25 2:35 ` Rafael J. Wysocki
2010-04-25 3:15 ` Rafael J. Wysocki
2010-04-26 15:05 ` Michal Hocko
2010-04-26 16:22 ` Len Brown
2010-04-27 7:04 ` Michal Hocko
2010-04-29 14:38 ` Tony Vroon
2010-04-26 18:51 ` Rafael J. Wysocki
2010-04-27 6:51 ` Michal Hocko
2010-04-27 22:06 ` Rafael J. Wysocki
2010-04-28 21:18 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004132253.37432.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mhocko@suse.cz \
--cc=mjg59@srcf.ucam.org \
--cc=tony@linx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).