* pull request: wireless-2.6 2010-04-15
@ 2010-04-15 20:03 John W. Linville
2010-04-15 21:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2010-04-15 20:03 UTC (permalink / raw)
To: davem; +Cc: linux-wireless, netdev, linux-kernel
Dave,
Another fix intended for 2.6.34...without it some firmware wierdness can
induce the driver into hanging the box... :-(
Please let me know if there are problems!
Thanks,
John
---
The following changes since commit 4eaa0e3c869acd5dbc7c2e3818a9ae9cbf221d27:
Eric Dumazet (1):
fib: suppress lockdep-RCU false positive in FIB trie.
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git master
Johannes Berg (1):
iwlwifi: work around bogus active chains detection
drivers/net/wireless/iwlwifi/iwl-calib.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-calib.c b/drivers/net/wireless/iwlwifi/iwl-calib.c
index 845831a..64de42b 100644
--- a/drivers/net/wireless/iwlwifi/iwl-calib.c
+++ b/drivers/net/wireless/iwlwifi/iwl-calib.c
@@ -807,6 +807,18 @@ void iwl_chain_noise_calibration(struct iwl_priv *priv,
}
}
+ /*
+ * The above algorithm sometimes fails when the ucode
+ * reports 0 for all chains. It's not clear why that
+ * happens to start with, but it is then causing trouble
+ * because this can make us enable more chains than the
+ * hardware really has.
+ *
+ * To be safe, simply mask out any chains that we know
+ * are not on the device.
+ */
+ active_chains &= priv->hw_params.valid_rx_ant;
+
num_tx_chains = 0;
for (i = 0; i < NUM_RX_CHAINS; i++) {
/* loops on all the bits of
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: pull request: wireless-2.6 2010-04-15
2010-04-15 20:03 pull request: wireless-2.6 2010-04-15 John W. Linville
@ 2010-04-15 21:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-04-15 21:29 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, netdev, linux-kernel
From: "John W. Linville" <linville@tuxdriver.com>
Date: Thu, 15 Apr 2010 16:03:31 -0400
> Another fix intended for 2.6.34...without it some firmware wierdness can
> induce the driver into hanging the box... :-(
>
> Please let me know if there are problems!
Pulled, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-15 21:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-15 20:03 pull request: wireless-2.6 2010-04-15 John W. Linville
2010-04-15 21:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).