linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Herrmann <herrmann.der.user@googlemail.com>
To: Christoph Lameter <cl@linux-foundation.org>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>
Cc: Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org
Subject: useless node/has_cpu sysfs attribute
Date: Thu, 15 Apr 2010 08:12:00 +0200	[thread overview]
Message-ID: <20100415061200.GC21517@alberich.amd.com> (raw)

Hi,

commit 99dcc3e5a94ed491fbef402831d8c0bbb267f995 (this_cpu: Page
allocator conversion) removed the call

    node_set_state(node, N_CPU);    /* this node has a cpu */

(in fact process_zones() where this call happened was removed).

Thus the sysfs attribute /sys/devices/system/node/has_cpu doesn't
show anything anymore.

Before this commit the attribute usually listed all nodes ("having a CPU")
in the system, e.g.

  worms linux # cat /sys/devices/system/node/has_cpu
  0-7

This attribute never reflected any changes triggered by CPU hotplug.
I.e. you could set all CPUs of a node offline but the node still was listed
in this attribute. (because no hotplug notifiers exist that would
call node_set_state(node, N_CPU)/node_clear_state(node,N_CPU)).

Do we need this attribute?
Who relies on information from this attribute?

I think if we do not need the attribute we should remove it. But if
there is use for it we need to fix it and make it CPU hotplug aware.

Opinions?


Thanks,

Andreas

PS: The attribute was introduced with commit
bde631a51876f23e9bbdce43f02b7232502c151e (mm: add node states sysfs
class attributeS)

             reply	other threads:[~2010-04-15  6:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-15  6:12 Andreas Herrmann [this message]
2010-04-16  0:27 ` useless node/has_cpu sysfs attribute Christoph Lameter
2010-04-16  7:26   ` Andreas Herrmann
2010-04-16 16:00     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100415061200.GC21517@alberich.amd.com \
    --to=herrmann.der.user@googlemail.com \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=andi@firstfloor.org \
    --cc=cl@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).