From: Andreas Herrmann <herrmann.der.user@googlemail.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: useless node/has_cpu sysfs attribute
Date: Fri, 16 Apr 2010 09:26:52 +0200 [thread overview]
Message-ID: <20100416072652.GA4489@alberich.amd.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1004151917420.17800@router.home>
On Thu, Apr 15, 2010 at 07:27:42PM -0500, Christoph Lameter wrote:
> On Thu, 15 Apr 2010, Andreas Herrmann wrote:
>
> > commit 99dcc3e5a94ed491fbef402831d8c0bbb267f995 (this_cpu: Page
> > allocator conversion) removed the call
> >
> > node_set_state(node, N_CPU); /* this node has a cpu */
> This was moved to vmstat_cpuup_callback. See mm/vmstat.c. Maybe it needs
> to be added to setup_vmstat() as well.
Ok.
I missed that one.
> > Thus the sysfs attribute /sys/devices/system/node/has_cpu doesn't
> > show anything anymore.
>
> Thats strange. Why is the cpuup notifier not executing?
I'll try to figure this out.
> > This attribute never reflected any changes triggered by CPU hotplug.
>
> Duh some breakage in the cpuup notifier handling?
>
> This needs to be fixed.
Why don't we try to call node_clear_state(node, N_CPU)
anywhere? (Maybe there is such a call and I missed it.)
Do we want to list each node with this attribute that has a CPU
regardless whether the CPU is actually offline or online?
That is the reason why I wanted to know who is relying on this
attribute and what are the use cases of it.
Thanks,
Andreas
next prev parent reply other threads:[~2010-04-16 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 6:12 useless node/has_cpu sysfs attribute Andreas Herrmann
2010-04-16 0:27 ` Christoph Lameter
2010-04-16 7:26 ` Andreas Herrmann [this message]
2010-04-16 16:00 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416072652.GA4489@alberich.amd.com \
--to=herrmann.der.user@googlemail.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).