From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Éric Piel" <Eric.Piel@tremplin-utc.net>
Cc: platform-driver-x86@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, "Brown, Len" <len.brown@intel.com>,
Matthew Garrett <mjg@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Make WMI be selected automatically when needed
Date: Fri, 16 Apr 2010 17:31:27 -0700 [thread overview]
Message-ID: <20100416173127.6b968fd4.randy.dunlap@oracle.com> (raw)
In-Reply-To: <4BC8FF9D.7050500@tremplin-utc.net>
On Sat, 17 Apr 2010 02:23:57 +0200 Éric Piel wrote:
> Many different modules depend on WMI. In Kconfig, some used to "depend"
> on it, while others "selected" it. As WMI by itself is useless and more
> like a library, it's easier for the user to have it automatically
> selected whenever needed. It's especially true for options in completely
> different places (like LEDS_DELL_NETBOOKS). So we consistently "select"
> it.
>
> Signed-off-by: Éric Piel <eric.piel@tremplin-utc.net>
config ACPI_WMI
tristate "WMI"
depends on ACPI
so what happens when one of these configs selects ACPI_WMI
but ACPI is not enabled? Hint: that will not enable ACPI.
Did you test that kconfig combination?
> ---
> drivers/leds/Kconfig | 3 ++-
> drivers/platform/x86/Kconfig | 8 ++++----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 505eb64..71e8a51 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -280,7 +280,8 @@ config LEDS_ADP5520
>
> config LEDS_DELL_NETBOOKS
> tristate "External LED on Dell Business Netbooks"
> - depends on X86 && ACPI_WMI
> + depends on X86
> + select ACPI_WMI
> help
> This adds support for the Latitude 2100 and similar
> notebooks that have an external LED.
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 7bec458..9808ef3 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -89,8 +89,8 @@ config DELL_LAPTOP
>
> config DELL_WMI
> tristate "Dell WMI extras"
> - depends on ACPI_WMI
> depends on INPUT
> + select ACPI_WMI
> ---help---
> Say Y here if you want to support WMI-based hotkeys on Dell laptops.
>
> @@ -136,9 +136,9 @@ config TC1100_WMI
>
> config HP_WMI
> tristate "HP WMI extras"
> - depends on ACPI_WMI
> depends on INPUT
> depends on RFKILL || RFKILL = n
> + select ACPI_WMI
> help
> Say Y here if you want to support WMI-based hotkeys on HP laptops and
> to read data from WMI such as docking or ambient light sensor state.
> @@ -387,9 +387,9 @@ config EEEPC_LAPTOP
>
> config EEEPC_WMI
> tristate "Eee PC WMI Hotkey Driver (EXPERIMENTAL)"
> - depends on ACPI_WMI
> depends on INPUT
> depends on EXPERIMENTAL
> + select ACPI_WMI
> ---help---
> Say Y here if you want to support WMI-based hotkeys on Eee PC laptops.
>
> @@ -419,9 +419,9 @@ config ACPI_WMI
>
> config MSI_WMI
> tristate "MSI WMI extras"
> - depends on ACPI_WMI
> depends on INPUT
> depends on BACKLIGHT_CLASS_DEVICE
> + select ACPI_WMI
> select INPUT_SPARSEKMAP
> help
> Say Y here if you want to support WMI-based hotkeys on MSI laptops.
> --
---
~Randy
next prev parent reply other threads:[~2010-04-17 0:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 0:23 [PATCH 1/2] Make WMI be selected automatically when needed Éric Piel
2010-04-17 0:31 ` Randy Dunlap [this message]
2010-04-17 0:58 ` Éric Piel
2010-04-23 19:20 ` Matthew Garrett
2010-04-23 19:51 ` Éric Piel
2010-04-23 20:04 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416173127.6b968fd4.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=Eric.Piel@tremplin-utc.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).