From: Matthew Garrett <mjg59@srcf.ucam.org>
To: "Éric Piel" <Eric.Piel@tremplin-utc.net>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
platform-driver-x86@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, "Brown, Len" <len.brown@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Make WMI be selected automatically when needed
Date: Fri, 23 Apr 2010 20:20:59 +0100 [thread overview]
Message-ID: <20100423192059.GA32705@srcf.ucam.org> (raw)
In-Reply-To: <4BC907B5.2050104@tremplin-utc.net>
On Sat, Apr 17, 2010 at 02:58:29AM +0200, Éric Piel wrote:
> config LEDS_DELL_NETBOOKS
> tristate "External LED on Dell Business Netbooks"
> - depends on X86 && ACPI_WMI
> + depends on X86
> + depends on ACPI
> + select ACPI_WMI
I dislike this. The originally stated dependencies are correct and more
accurately represent what the code requires, and changing that for the
sake of making it easier for people to find the driver sounds like it's
trying to cover up shortcomings in our configuration system more than
anything else.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-04-23 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-17 0:23 [PATCH 1/2] Make WMI be selected automatically when needed Éric Piel
2010-04-17 0:31 ` Randy Dunlap
2010-04-17 0:58 ` Éric Piel
2010-04-23 19:20 ` Matthew Garrett [this message]
2010-04-23 19:51 ` Éric Piel
2010-04-23 20:04 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423192059.GA32705@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Eric.Piel@tremplin-utc.net \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).