linux-next: build warning after merge of the driver-core.current tree

linux-next: build warning after merge of the driver-core.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

Hi Grant,

After merging the driver-core.current tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:

drivers/base/firmware_class.c: In function 'release_firmware':
drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type
drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'

Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0
("firmware_class: fix memory leak - free allocated pages").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warning after merge of the driver-core.current tree

[Greg KH]

On Fri, Apr 30, 2010 at 09:35:34AM +1000, Stephen Rothwell wrote:
> Hi Grant,
> 
> After merging the driver-core.current tree, today's linux-next build
> (x86_64 allmodconfig) produced this warning:
> 
> drivers/base/firmware_class.c: In function 'release_firmware':
> drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type
> drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
> 
> Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0
> ("firmware_class: fix memory leak - free allocated pages").

Thanks, I've fixed this up, the release call should not have 'const'
on it as it is going to touch the pointer passed to it :)

thanks,

greg k-h

Re: linux-next: build warning after merge of the driver-core.current tree

[Greg KH]

On Thu, Apr 29, 2010 at 04:43:47PM -0700, Greg KH wrote:
> On Fri, Apr 30, 2010 at 09:35:34AM +1000, Stephen Rothwell wrote:
> > Hi Grant,
> > 
> > After merging the driver-core.current tree, today's linux-next build
> > (x86_64 allmodconfig) produced this warning:
> > 
> > drivers/base/firmware_class.c: In function 'release_firmware':
> > drivers/base/firmware_class.c:597: warning: passing argument 1 of 'firmware_free_data' discards qualifiers from pointer target type
> > drivers/base/firmware_class.c:133: note: expected 'struct firmware *' but argument is of type 'const struct firmware *'
> > 
> > Introduced by commit 6454d23dedf4019fcae868818ae63c755dd42be0
> > ("firmware_class: fix memory leak - free allocated pages").
> 
> Thanks, I've fixed this up, the release call should not have 'const'
> on it as it is going to touch the pointer passed to it :)

And it's now pushed out in my tree.

thanks,

greg k-h

Re: linux-next: build warning after merge of the driver-core.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi Greg,

On Thu, 29 Apr 2010 16:45:25 -0700 Greg KH <greg@kroah.com> wrote:
>
> > Thanks, I've fixed this up, the release call should not have 'const'
> > on it as it is going to touch the pointer passed to it :)
> 
> And it's now pushed out in my tree.

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

linux-next: build warning after merge of the driver-core.current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi all,

After merging the driver-core.current tree, today's linux-next build
(x86_64 allnoconfig) produced this warning:

drivers/base/topology.c: In function 'topology_is_visible':
drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
  158 |         struct device *dev = kobj_to_dev(kobj);
      |                        ^~~

Introduced by commit

  aa63a74d4535 ("topology/sysfs: Hide PPIN on systems that do not support it.")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the driver-core.current tree

[Greg KH]

On Thu, Apr 21, 2022 at 03:26:45PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the driver-core.current tree, today's linux-next build
> (x86_64 allnoconfig) produced this warning:
> 
> drivers/base/topology.c: In function 'topology_is_visible':
> drivers/base/topology.c:158:24: warning: unused variable 'dev' [-Wunused-variable]
>   158 |         struct device *dev = kobj_to_dev(kobj);
>       |                        ^~~
> 
> Introduced by commit
> 
>   aa63a74d4535 ("topology/sysfs: Hide PPIN on systems that do not support it.")

Tony, can you please send a fixup patch for this, or should I just
revert this commit for now?

thanks,

greg k-h