* [PATCH] fbdev: section cleanup in viafb driver
@ 2010-06-17 10:01 Henrik Kretzschmar
2010-06-24 20:17 ` Jonathan Corbet
2010-06-26 2:31 ` coffbeta
0 siblings, 2 replies; 3+ messages in thread
From: Henrik Kretzschmar @ 2010-06-17 10:01 UTC (permalink / raw)
To: JosephChan, ScottFang
Cc: corbet, FlorianSchandinat, linux-fbdev, linux-kernel, Henrik Kretzschmar
This patch moves two functions from .devexit to .text,
which are called on the probe error path.
Also a function which is called by probe is moved
from .text to .devinit.
WARNING: vmlinux.o(.devinit.text+0x2ca5): Section mismatch in reference
from the function via_pci_probe() to the function
.devexit.text:via_teardown_subdevs()
The function __devinit via_pci_probe() references
a function __devexit via_teardown_subdevs().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
via_teardown_subdevs() so it may be used outside an exit section.
WARNING: vmlinux.o(.devinit.text+0x2cb1): Section mismatch in reference
from the function via_pci_probe() to the function
.devexit.text:via_pci_teardown_mmio()
The function __devinit via_pci_probe() references
a function __devexit via_pci_teardown_mmio().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
via_pci_teardown_mmio() so it may be used outside an exit section.
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
This patch is compile tested against Linus lastest git kernel.
drivers/video/via/via-core.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/via/via-core.c b/drivers/video/via/via-core.c
index e8cfe83..ec2e5aa 100644
--- a/drivers/video/via/via-core.c
+++ b/drivers/video/via/via-core.c
@@ -64,7 +64,7 @@ static inline int viafb_mmio_read(int reg)
*/
static u32 viafb_enabled_ints;
-static void viafb_int_init(void)
+static void __devinit viafb_int_init(void)
{
viafb_enabled_ints = 0;
@@ -489,7 +489,7 @@ out_unmap:
return ret;
}
-static void __devexit via_pci_teardown_mmio(struct viafb_dev *vdev)
+static void via_pci_teardown_mmio(struct viafb_dev *vdev)
{
iounmap(vdev->fbmem);
iounmap(vdev->engine_mmio);
@@ -548,7 +548,7 @@ static int __devinit via_setup_subdevs(struct viafb_dev *vdev)
return 0;
}
-static void __devexit via_teardown_subdevs(void)
+static void via_teardown_subdevs(void)
{
int i;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev: section cleanup in viafb driver
2010-06-17 10:01 [PATCH] fbdev: section cleanup in viafb driver Henrik Kretzschmar
@ 2010-06-24 20:17 ` Jonathan Corbet
2010-06-26 2:31 ` coffbeta
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2010-06-24 20:17 UTC (permalink / raw)
To: Henrik Kretzschmar
Cc: JosephChan, ScottFang, FlorianSchandinat, linux-fbdev, linux-kernel
On Thu, 17 Jun 2010 12:01:24 +0200
Henrik Kretzschmar <henne@nachtwindheim.de> wrote:
> This patch moves two functions from .devexit to .text,
> which are called on the probe error path.
> Also a function which is called by probe is moved
> from .text to .devinit.
Sorry, it took me a while to take a look at this. The changes make
sense, thanks. I have a few viafb bits and pieces, will collect them
into my tree shortly.
Thanks,
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fbdev: section cleanup in viafb driver
2010-06-17 10:01 [PATCH] fbdev: section cleanup in viafb driver Henrik Kretzschmar
2010-06-24 20:17 ` Jonathan Corbet
@ 2010-06-26 2:31 ` coffbeta
1 sibling, 0 replies; 3+ messages in thread
From: coffbeta @ 2010-06-26 2:31 UTC (permalink / raw)
To: Henrik Kretzschmar, Andy Shevchenko, Andy Shevchenko,
Jason Wessel, kgdb-bugreport, linux-kernel, Martin Hicks
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2973 bytes --]
-static void __devexit via_teardown_subdevs(void)
------------------
coffbeta
2010-06-26
-------------------------------------------------------------
·¢¼þÈË£ºHenrik Kretzschmar
·¢ËÍÈÕÆÚ£º2010-06-17 18:09:34
ÊÕ¼þÈË£ºJosephChan; ScottFang
³ËÍ£ºcorbet; FlorianSchandinat; linux-fbdev; linux-kernel; Henrik Kretzschmar
Ö÷Ì⣺[PATCH] fbdev: section cleanup in viafb driver
This patch moves two functions from .devexit to .text,
which are called on the probe error path.
Also a function which is called by probe is moved
from .text to .devinit.
WARNING: vmlinux.o(.devinit.text+0x2ca5): Section mismatch in reference
from the function via_pci_probe() to the function
.devexit.text:via_teardown_subdevs()
The function __devinit via_pci_probe() references
a function __devexit via_teardown_subdevs().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
via_teardown_subdevs() so it may be used outside an exit section.
WARNING: vmlinux.o(.devinit.text+0x2cb1): Section mismatch in reference
from the function via_pci_probe() to the function
.devexit.text:via_pci_teardown_mmio()
The function __devinit via_pci_probe() references
a function __devexit via_pci_teardown_mmio().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
via_pci_teardown_mmio() so it may be used outside an exit section.
Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
---
This patch is compile tested against Linus lastest git kernel.
drivers/video/via/via-core.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/via/via-core.c b/drivers/video/via/via-core.c
index e8cfe83..ec2e5aa 100644
--- a/drivers/video/via/via-core.c
+++ b/drivers/video/via/via-core.c
@@ -64,7 +64,7 @@ static inline int viafb_mmio_read(int reg)
*/
static u32 viafb_enabled_ints;
-static void viafb_int_init(void)
+static void __devinit viafb_int_init(void)
{
viafb_enabled_ints = 0;
@@ -489,7 +489,7 @@ out_unmap:
return ret;
}
-static void __devexit via_pci_teardown_mmio(struct viafb_dev *vdev)
+static void via_pci_teardown_mmio(struct viafb_dev *vdev)
{
iounmap(vdev->fbmem);
iounmap(vdev->engine_mmio);
@@ -548,7 +548,7 @@ static int __devinit via_setup_subdevs(struct viafb_dev *vdev)
return 0;
}
-static void __devexit via_teardown_subdevs(void)
+static void via_teardown_subdevs(void)
{
int i;
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-26 2:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-17 10:01 [PATCH] fbdev: section cleanup in viafb driver Henrik Kretzschmar
2010-06-24 20:17 ` Jonathan Corbet
2010-06-26 2:31 ` coffbeta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).