* [PATCH] Expose vendor-specific ACM channel on Nokia 5230
@ 2010-06-28 20:29 Przemo Firszt
2010-06-28 20:59 ` Oliver Neukum
0 siblings, 1 reply; 4+ messages in thread
From: Przemo Firszt @ 2010-06-28 20:29 UTC (permalink / raw)
To: oliver, gregkh, alan, francescolavra, julian.calaby
Cc: linux-usb, linux-kernel, Przemo Firszt
Nokia S60 phones expose two ACM channels. The first is
a modem, the second is 'vendor-specific' but is treated
as a serial device at the S60 end, so we want to expose
it on Linux too.
Signed-off-by: Przemo Firszt <przemo@firszt.eu>
---
drivers/usb/class/cdc-acm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 61d7550..162c95a 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1596,6 +1596,7 @@ static const struct usb_device_id acm_ids[] = {
{ NOKIA_PCSUITE_ACM_INFO(0x00e9), }, /* Nokia 5320 XpressMusic */
{ NOKIA_PCSUITE_ACM_INFO(0x0108), }, /* Nokia 5320 XpressMusic 2G */
{ NOKIA_PCSUITE_ACM_INFO(0x01f5), }, /* Nokia N97, RM-505 */
+ { NOKIA_PCSUITE_ACM_INFO(0x02e3), }, /* Nokia 5230, RM-588 */
/* NOTE: non-Nokia COMM/ACM/0xff is likely MSFT RNDIS... NOT a modem! */
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Expose vendor-specific ACM channel on Nokia 5230
2010-06-28 20:29 [PATCH] Expose vendor-specific ACM channel on Nokia 5230 Przemo Firszt
@ 2010-06-28 20:59 ` Oliver Neukum
2010-06-29 17:43 ` Przemo Firszt
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Neukum @ 2010-06-28 20:59 UTC (permalink / raw)
To: Przemo Firszt
Cc: oliver, gregkh, alan, francescolavra, julian.calaby, linux-usb,
linux-kernel
Am Montag, 28. Juni 2010, 22:29:34 schrieb Przemo Firszt:
> Nokia S60 phones expose two ACM channels. The first is
> a modem, the second is 'vendor-specific' but is treated
> as a serial device at the S60 end, so we want to expose
> it on Linux too.
>
I see. We want to expose it. But do we want to expose it as an acm interface?
Regards
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Expose vendor-specific ACM channel on Nokia 5230
2010-06-28 20:59 ` Oliver Neukum
@ 2010-06-29 17:43 ` Przemo Firszt
2010-06-30 13:43 ` Oliver Neukum
0 siblings, 1 reply; 4+ messages in thread
From: Przemo Firszt @ 2010-06-29 17:43 UTC (permalink / raw)
To: Oliver Neukum
Cc: oliver, gregkh, alan, francescolavra, julian.calaby, linux-usb,
linux-kernel
Dnia 2010-06-28, pon o godzinie 22:59 +0200, Oliver Neukum pisze:
> Am Montag, 28. Juni 2010, 22:29:34 schrieb Przemo Firszt:
> > Nokia S60 phones expose two ACM channels. The first is
> > a modem, the second is 'vendor-specific' but is treated
> > as a serial device at the S60 end, so we want to expose
> > it on Linux too.
> >
>
> I see. We want to expose it. But do we want to expose it as an acm interface?
>
> Regards
> Oliver
It's just continuation of [1]. I don't feel pressure to do it that way
if there are any better ideas.
[1] http://article.gmane.org/gmane.linux.kernel.commits.head/221222
--
Kind regards,
Przemo Firszt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Expose vendor-specific ACM channel on Nokia 5230
2010-06-29 17:43 ` Przemo Firszt
@ 2010-06-30 13:43 ` Oliver Neukum
0 siblings, 0 replies; 4+ messages in thread
From: Oliver Neukum @ 2010-06-30 13:43 UTC (permalink / raw)
To: Przemo Firszt
Cc: oliver, gregkh, alan, francescolavra, julian.calaby, linux-usb,
linux-kernel
Am Dienstag, 29. Juni 2010, 19:43:23 schrieb Przemo Firszt:
> Dnia 2010-06-28, pon o godzinie 22:59 +0200, Oliver Neukum pisze:
> > Am Montag, 28. Juni 2010, 22:29:34 schrieb Przemo Firszt:
> > > Nokia S60 phones expose two ACM channels. The first is
> > > a modem, the second is 'vendor-specific' but is treated
> > > as a serial device at the S60 end, so we want to expose
> > > it on Linux too.
> > >
> >
> > I see. We want to expose it. But do we want to expose it as an acm interface?
> >
> > Regards
> > Oliver
> It's just continuation of [1]. I don't feel pressure to do it that way
> if there are any better ideas.
I see. Let's do it.
Regards
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-30 13:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-28 20:29 [PATCH] Expose vendor-specific ACM channel on Nokia 5230 Przemo Firszt
2010-06-28 20:59 ` Oliver Neukum
2010-06-29 17:43 ` Przemo Firszt
2010-06-30 13:43 ` Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).