linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: TTY: warning in tty_lock on 2.6.35+gregkh tree
  2010-08-07 11:21 TTY: warning in tty_lock on 2.6.35+gregkh tree Ming Lei
@ 2010-08-07  7:54 ` Arnd Bergmann
  2010-08-07  8:35   ` Ming Lei
  0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2010-08-07  7:54 UTC (permalink / raw)
  To: Ming Lei; +Cc: linux-kernel, gregkh

On Saturday 07 August 2010, Ming Lei wrote:
> Following the ttty warning during kernel boot, seems it is for a long time
> in gregkh's tree.

The fix for this is in the bkl/core tree, meaning it doesn't show up
in the linux-next tree.

The warning by itself is harmless, so there was no strict need to
coordinate this better. In fact, with the removal of the optional
BKL behavior, I believe the warning is now gone from the tty
tree as well.

	Arnd

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: TTY: warning in tty_lock on 2.6.35+gregkh tree
  2010-08-07  7:54 ` Arnd Bergmann
@ 2010-08-07  8:35   ` Ming Lei
  0 siblings, 0 replies; 3+ messages in thread
From: Ming Lei @ 2010-08-07  8:35 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: linux-kernel, gregkh

2010/8/7 Arnd Bergmann <arnd@arndb.de>:
> On Saturday 07 August 2010, Ming Lei wrote:
>> Following the ttty warning during kernel boot, seems it is for a long time
>> in gregkh's tree.
>
> The fix for this is in the bkl/core tree, meaning it doesn't show up
> in the linux-next tree.
>
> The warning by itself is harmless, so there was no strict need to
> coordinate this better. In fact, with the removal of the optional
> BKL behavior, I believe the warning is now gone from the tty
> tree as well.

Oh, I see, thanks.

-- 
Lei Ming

^ permalink raw reply	[flat|nested] 3+ messages in thread

* TTY: warning in tty_lock on 2.6.35+gregkh tree
@ 2010-08-07 11:21 Ming Lei
  2010-08-07  7:54 ` Arnd Bergmann
  0 siblings, 1 reply; 3+ messages in thread
From: Ming Lei @ 2010-08-07 11:21 UTC (permalink / raw)
  To: linux-kernel, gregkh


Hi,

Following the ttty warning during kernel boot, seems it is for a long time
in gregkh's tree.

[    0.660082] ------------[ cut here ]------------
[    0.660088] WARNING: at include/linux/tty.h:590 tty_lock+0x24/0x3e()
[    0.660089] Hardware name:        
[    0.660091] Modules linked in:
[    0.660094] Pid: 1, comm: swapper Not tainted 2.6.35-gkh-wl+ #51
[    0.660096] Call Trace:
[    0.660101]  [<ffffffff8104766a>] warn_slowpath_common+0x80/0x98
[    0.660105]  [<ffffffff81047697>] warn_slowpath_null+0x15/0x17
[    0.660108]  [<ffffffff8123a5a3>] tty_lock+0x24/0x3e
[    0.660111]  [<ffffffff8123d69c>] tty_open+0x60/0x4a4
[    0.660115]  [<ffffffff810e81be>] chrdev_open+0x134/0x155
[    0.660118]  [<ffffffff810e808a>] ? chrdev_open+0x0/0x155
[    0.660122]  [<ffffffff810e4074>] __dentry_open+0x147/0x27d
[    0.660125]  [<ffffffff810e426f>] nameidata_to_filp+0x3a/0x4b
[    0.660137]  [<ffffffff810ef69c>] do_last+0x472/0x5b9
[    0.660140]  [<ffffffff810efc1b>] do_filp_open+0x1ee/0x5f1
[    0.660144]  [<ffffffff8106164a>] ? sched_clock_cpu+0xc3/0xce
[    0.660147]  [<ffffffff8106aba1>] ? lockstat_clock+0x11/0x13
[    0.660151]  [<ffffffff8136ff42>] ? _raw_spin_unlock+0x3e/0x4c
[    0.660155]  [<ffffffff810f99f5>] ? alloc_fd+0x111/0x123
[    0.660158]  [<ffffffff810e3e44>] do_sys_open+0x5e/0x10a
[    0.660162]  [<ffffffff81059765>] ? flush_workqueue+0x0/0xa7
[    0.660166]  [<ffffffff810e3f19>] sys_open+0x1b/0x1d
[    0.660170]  [<ffffffff81892745>] kernel_init+0x1b5/0x222
[    0.660174]  [<ffffffff8100a8e4>] kernel_thread_helper+0x4/0x10
[    0.660177]  [<ffffffff81370694>] ? restore_args+0x0/0x30
[    0.660181]  [<ffffffff81892590>] ? kernel_init+0x0/0x222
[    0.660183]  [<ffffffff8100a8e0>] ? kernel_thread_helper+0x0/0x10
[    0.660185] ---[ end trace f777fed7c0166a97 ]---
[    0.660369] ------------[ cut here ]------------
[    0.660372] WARNING: at include/linux/tty.h:590 tty_lock+0x24/0x3e()
[    0.660374] Hardware name:        
[    0.660375] Modules linked in:
[    0.660378] Pid: 1, comm: swapper Tainted: G        W   2.6.35-gkh-wl+ #51
[    0.660379] Call Trace:
[    0.660382]  [<ffffffff8104766a>] warn_slowpath_common+0x80/0x98
[    0.660386]  [<ffffffff81047697>] warn_slowpath_null+0x15/0x17
[    0.660388]  [<ffffffff8123a5a3>] tty_lock+0x24/0x3e
[    0.660391]  [<ffffffff8123dab9>] tty_open+0x47d/0x4a4
[    0.660394]  [<ffffffff810e81be>] chrdev_open+0x134/0x155
[    0.660397]  [<ffffffff810e808a>] ? chrdev_open+0x0/0x155
[    0.660399]  [<ffffffff810e4074>] __dentry_open+0x147/0x27d
[    0.660402]  [<ffffffff810e426f>] nameidata_to_filp+0x3a/0x4b
[    0.660405]  [<ffffffff810ef69c>] do_last+0x472/0x5b9
[    0.660408]  [<ffffffff810efc1b>] do_filp_open+0x1ee/0x5f1
[    0.660411]  [<ffffffff8106164a>] ? sched_clock_cpu+0xc3/0xce
[    0.660414]  [<ffffffff8106aba1>] ? lockstat_clock+0x11/0x13
[    0.660417]  [<ffffffff8136ff42>] ? _raw_spin_unlock+0x3e/0x4c
[    0.660420]  [<ffffffff810f99f5>] ? alloc_fd+0x111/0x123
[    0.660430]  [<ffffffff810e3e44>] do_sys_open+0x5e/0x10a
[    0.660433]  [<ffffffff81059765>] ? flush_workqueue+0x0/0xa7
[    0.660437]  [<ffffffff810e3f19>] sys_open+0x1b/0x1d
[    0.660440]  [<ffffffff81892745>] kernel_init+0x1b5/0x222
[    0.660443]  [<ffffffff8100a8e4>] kernel_thread_helper+0x4/0x10
[    0.660446]  [<ffffffff81370694>] ? restore_args+0x0/0x30
[    0.660449]  [<ffffffff81892590>] ? kernel_init+0x0/0x222
[    0.660452]  [<ffffffff8100a8e0>] ? kernel_thread_helper+0x0/0x10
[    0.660454] ---[ end trace f777fed7c0166a98 ]---

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-08-07  8:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-07 11:21 TTY: warning in tty_lock on 2.6.35+gregkh tree Ming Lei
2010-08-07  7:54 ` Arnd Bergmann
2010-08-07  8:35   ` Ming Lei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).